2023-07-03 03:52:32

by Li zeming

Subject: [PATCH] kernel: kprobes: Remove unnecessary ‘0’ values from ret

ret is assigned first, so it does not need to initialize the assignment.

Signed-off-by: Li zeming <[email protected]>
---
kernel/kprobes.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/kprobes.c b/kernel/kprobes.c
index ec50f9f380c1..a009c8ccd8ea 100644
--- a/kernel/kprobes.c
+++ b/kernel/kprobes.c
@@ -2692,7 +2692,7 @@ void kprobe_free_init_mem(void)

static int __init init_kprobes(void)
{
- int i, err = 0;
+ int i, err;

/* FIXME allocate the probe table, currently defined statically */
/* initialize all list heads */
--
2.18.2

2023-07-06 14:31:46

by Masami Hiramatsu

Subject: Re: [PATCH] kernel: kprobes: Remove unnecessary ‘0’ values from ret

On Wed, 5 Jul 2023 04:10:56 +0800
Li zeming <[email protected]> wrote:

> ret is assigned first, so it does not need to initialize the assignment.
>

OK, but can you merge this to the first one?
https://lore.kernel.org/all/[email protected]/

Thank you,

> Signed-off-by: Li zeming <[email protected]>
> ---
> kernel/kprobes.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/kprobes.c b/kernel/kprobes.c
> index ec50f9f380c1..a009c8ccd8ea 100644
> --- a/kernel/kprobes.c
> +++ b/kernel/kprobes.c
> @@ -2692,7 +2692,7 @@ void kprobe_free_init_mem(void)
>
> static int __init init_kprobes(void)
> {
> - int i, err = 0;
> + int i, err;
>
> /* FIXME allocate the probe table, currently defined statically */
> /* initialize all list heads */
> --
> 2.18.2
>


--
Masami Hiramatsu (Google) <[email protected]>