2023-07-04 13:04:19

by Masami Hiramatsu

[permalink] [raw]
Subject: Re: [PATCH] proc.5: Clarify that boot arguments can be embedded in image

On Fri, 30 Jun 2023 16:33:28 -0700
"Paul E. McKenney" <[email protected]> wrote:

> With the advent of the CONFIG_BOOT_CONFIG Kconfig option, kernel boot
> arguments can now be embedded in the kernel image, either attached
> to the end of initramfs or embedded in the kernel itself. Document
> this possibility in the /proc/cmdline entry of proc.5.

Thanks for update!

Reviewed-by: Masami Hiramatsu (Google) <[email protected]>

>
> Signed-off-by: Paul E. McKenney <[email protected]>
> Cc: Michael Kerrisk <[email protected]>
> Cc: Masami Hiramatsu <[email protected]>
> Cc: Jonathan Corbet <[email protected]>
> Cc: Andrew Morton <[email protected]>
> Cc: Nick Desaulniers <[email protected]>
> Cc: Vlastimil Babka <[email protected]>
> Cc: Johannes Weiner <[email protected]>
>
> diff --git a/man5/proc.5 b/man5/proc.5
> index c6684620e..141a2983c 100644
> --- a/man5/proc.5
> +++ b/man5/proc.5
> @@ -3100,6 +3100,9 @@ Often done via a boot manager such as
> .BR lilo (8)
> or
> .BR grub (8).
> +Any arguments embedded in the kernel image or initramfs via
> +.B CONFIG_BOOT_CONFIG
> +will also be displayed.
> .TP
> .IR /proc/config.gz " (since Linux 2.6)"
> This file exposes the configuration options that were used


--
Masami Hiramatsu (Google) <[email protected]>


2023-07-05 21:08:26

by Paul E. McKenney

[permalink] [raw]
Subject: Re: [PATCH] proc.5: Clarify that boot arguments can be embedded in image

On Tue, Jul 04, 2023 at 09:59:32PM +0900, Masami Hiramatsu wrote:
> On Fri, 30 Jun 2023 16:33:28 -0700
> "Paul E. McKenney" <[email protected]> wrote:
>
> > With the advent of the CONFIG_BOOT_CONFIG Kconfig option, kernel boot
> > arguments can now be embedded in the kernel image, either attached
> > to the end of initramfs or embedded in the kernel itself. Document
> > this possibility in the /proc/cmdline entry of proc.5.
>
> Thanks for update!
>
> Reviewed-by: Masami Hiramatsu (Google) <[email protected]>

Thank you, Masami!

Adding Alejandro and linux-man on CC.

Thanx, Paul

> > Signed-off-by: Paul E. McKenney <[email protected]>
> > Cc: Michael Kerrisk <[email protected]>
> > Cc: Masami Hiramatsu <[email protected]>
> > Cc: Jonathan Corbet <[email protected]>
> > Cc: Andrew Morton <[email protected]>
> > Cc: Nick Desaulniers <[email protected]>
> > Cc: Vlastimil Babka <[email protected]>
> > Cc: Johannes Weiner <[email protected]>
> >
> > diff --git a/man5/proc.5 b/man5/proc.5
> > index c6684620e..141a2983c 100644
> > --- a/man5/proc.5
> > +++ b/man5/proc.5
> > @@ -3100,6 +3100,9 @@ Often done via a boot manager such as
> > .BR lilo (8)
> > or
> > .BR grub (8).
> > +Any arguments embedded in the kernel image or initramfs via
> > +.B CONFIG_BOOT_CONFIG
> > +will also be displayed.
> > .TP
> > .IR /proc/config.gz " (since Linux 2.6)"
> > This file exposes the configuration options that were used
>
>
> --
> Masami Hiramatsu (Google) <[email protected]>

2023-07-08 18:38:08

by Alejandro Colomar

[permalink] [raw]
Subject: Re: [PATCH] proc.5: Clarify that boot arguments can be embedded in image

Hi Paul!

On 7/5/23 22:33, Paul E. McKenney wrote:
> On Tue, Jul 04, 2023 at 09:59:32PM +0900, Masami Hiramatsu wrote:
>> On Fri, 30 Jun 2023 16:33:28 -0700
>> "Paul E. McKenney" <[email protected]> wrote:
>>
>>> With the advent of the CONFIG_BOOT_CONFIG Kconfig option, kernel boot
>>> arguments can now be embedded in the kernel image, either attached
>>> to the end of initramfs or embedded in the kernel itself. Document
>>> this possibility in the /proc/cmdline entry of proc.5.
>>
>> Thanks for update!
>>
>> Reviewed-by: Masami Hiramatsu (Google) <[email protected]>
>

Thanks for the review! Tag added.

> Thank you, Masami!
>
> Adding Alejandro and linux-man on CC.
>
> Thanx, Paul
>
>>> Signed-off-by: Paul E. McKenney <[email protected]>
>>> Cc: Michael Kerrisk <[email protected]>
>>> Cc: Masami Hiramatsu <[email protected]>
>>> Cc: Jonathan Corbet <[email protected]>
>>> Cc: Andrew Morton <[email protected]>
>>> Cc: Nick Desaulniers <[email protected]>
>>> Cc: Vlastimil Babka <[email protected]>
>>> Cc: Johannes Weiner <[email protected]>
>>>

Thanks! Patch applied.

Cheers,
Alex

>>> diff --git a/man5/proc.5 b/man5/proc.5
>>> index c6684620e..141a2983c 100644
>>> --- a/man5/proc.5
>>> +++ b/man5/proc.5
>>> @@ -3100,6 +3100,9 @@ Often done via a boot manager such as
>>> .BR lilo (8)
>>> or
>>> .BR grub (8).
>>> +Any arguments embedded in the kernel image or initramfs via
>>> +.B CONFIG_BOOT_CONFIG
>>> +will also be displayed.
>>> .TP
>>> .IR /proc/config.gz " (since Linux 2.6)"
>>> This file exposes the configuration options that were used
>>
>>
>> --
>> Masami Hiramatsu (Google) <[email protected]>

--
<http://www.alejandro-colomar.es/>
GPG key fingerprint: A9348594CE31283A826FBDD8D57633D441E25BB5


Attachments:
OpenPGP_signature (849.00 B)
OpenPGP digital signature