2023-07-05 02:10:19

by Sherry Sun

[permalink] [raw]
Subject: [PATCH V4 0/3] correct the lpuart compatible for imx8dxl and imx93

This patch set corrects the lpuart compatible for imx8dxl and imx93 platforms,
also correct the corresponding fsl-lpuart dt-binding doc.

---
Changes in V4
1. add Reviewed-by tag for patch#3

Changes in V3
1. remove the redundant fsl,imx8ulp-lpuart entry in patch#3
2. change const to enum for better readability in patch#3

Changes in V2
1. drop the imx8ulp dts changes in last version patch set
2. add both "fsl,imx8ulp-lpuart" and "fsl,imx7ulp-lpuart" for imx93
3. correct the dt-bindings for imx93 lpuart compatible
---

Sherry Sun (3):
arm64: dts: imx8dxl: remove "fsl,imx7ulp-lpuart" compatible for
imx8dxl
arm64: dts: imx93: add "fsl,imx8ulp-lpuart" compatible for imx93
dt-bindings: serial: fsl-lpuart: correct imx93-lpuart dt-binding item

.../devicetree/bindings/serial/fsl-lpuart.yaml | 6 +++++-
.../boot/dts/freescale/imx8dxl-ss-adma.dtsi | 8 ++++----
arch/arm64/boot/dts/freescale/imx93.dtsi | 16 ++++++++--------
3 files changed, 17 insertions(+), 13 deletions(-)

--
2.17.1



2023-07-05 02:16:35

by Sherry Sun

[permalink] [raw]
Subject: [PATCH V4 3/3] dt-bindings: serial: fsl-lpuart: correct imx93-lpuart dt-binding item

Correct the fsl,imx93-lpuart dt-binding item, imx93/imx8ulp add some new
features based on imx7ulp lpuart, so need to add "fsl,imx8ulp-lpuart"
for imx93 to enable those new features.

Signed-off-by: Sherry Sun <[email protected]>
Reviewed-by: Krzysztof Kozlowski <[email protected]>
---
Documentation/devicetree/bindings/serial/fsl-lpuart.yaml | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
index 93062403276b..3a5b59f5d3e3 100644
--- a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
+++ b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
@@ -25,9 +25,13 @@ properties:
- fsl,imxrt1050-lpuart
- items:
- enum:
- - fsl,imx93-lpuart
- fsl,imx8ulp-lpuart
- const: fsl,imx7ulp-lpuart
+ - items:
+ - enum:
+ - fsl,imx93-lpuart
+ - const: fsl,imx8ulp-lpuart
+ - const: fsl,imx7ulp-lpuart
- items:
- enum:
- fsl,imx8qm-lpuart
--
2.17.1


2023-07-05 02:24:08

by Sherry Sun

[permalink] [raw]
Subject: [PATCH V4 2/3] arm64: dts: imx93: add "fsl,imx8ulp-lpuart" compatible for imx93

i.MX93 and i.MX8ULP lpuart add some new featurs based on i.MX7ULP, for
example, i.MX93 and i.MX8ULP can support EOP(end-of-packet) function
while i.MX7ULP doesn't support, so add "fsl,imx8ulp-lpuart" compatible
string for i.MX93 to support those new features.

Signed-off-by: Sherry Sun <[email protected]>
---
arch/arm64/boot/dts/freescale/imx93.dtsi | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi b/arch/arm64/boot/dts/freescale/imx93.dtsi
index 8643612ace8c..16da5ef578c5 100644
--- a/arch/arm64/boot/dts/freescale/imx93.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx93.dtsi
@@ -252,7 +252,7 @@
};

lpuart1: serial@44380000 {
- compatible = "fsl,imx93-lpuart", "fsl,imx7ulp-lpuart";
+ compatible = "fsl,imx93-lpuart", "fsl,imx8ulp-lpuart", "fsl,imx7ulp-lpuart";
reg = <0x44380000 0x1000>;
interrupts = <GIC_SPI 19 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clk IMX93_CLK_LPUART1_GATE>;
@@ -261,7 +261,7 @@
};

lpuart2: serial@44390000 {
- compatible = "fsl,imx93-lpuart", "fsl,imx7ulp-lpuart";
+ compatible = "fsl,imx93-lpuart", "fsl,imx8ulp-lpuart", "fsl,imx7ulp-lpuart";
reg = <0x44390000 0x1000>;
interrupts = <GIC_SPI 20 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clk IMX93_CLK_LPUART2_GATE>;
@@ -486,7 +486,7 @@
};

lpuart3: serial@42570000 {
- compatible = "fsl,imx93-lpuart", "fsl,imx7ulp-lpuart";
+ compatible = "fsl,imx93-lpuart", "fsl,imx8ulp-lpuart", "fsl,imx7ulp-lpuart";
reg = <0x42570000 0x1000>;
interrupts = <GIC_SPI 68 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clk IMX93_CLK_LPUART3_GATE>;
@@ -495,7 +495,7 @@
};

lpuart4: serial@42580000 {
- compatible = "fsl,imx93-lpuart", "fsl,imx7ulp-lpuart";
+ compatible = "fsl,imx93-lpuart", "fsl,imx8ulp-lpuart", "fsl,imx7ulp-lpuart";
reg = <0x42580000 0x1000>;
interrupts = <GIC_SPI 69 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clk IMX93_CLK_LPUART4_GATE>;
@@ -504,7 +504,7 @@
};

lpuart5: serial@42590000 {
- compatible = "fsl,imx93-lpuart", "fsl,imx7ulp-lpuart";
+ compatible = "fsl,imx93-lpuart", "fsl,imx8ulp-lpuart", "fsl,imx7ulp-lpuart";
reg = <0x42590000 0x1000>;
interrupts = <GIC_SPI 70 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clk IMX93_CLK_LPUART5_GATE>;
@@ -513,7 +513,7 @@
};

lpuart6: serial@425a0000 {
- compatible = "fsl,imx93-lpuart", "fsl,imx7ulp-lpuart";
+ compatible = "fsl,imx93-lpuart", "fsl,imx8ulp-lpuart", "fsl,imx7ulp-lpuart";
reg = <0x425a0000 0x1000>;
interrupts = <GIC_SPI 71 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clk IMX93_CLK_LPUART6_GATE>;
@@ -551,7 +551,7 @@
};

lpuart7: serial@42690000 {
- compatible = "fsl,imx93-lpuart", "fsl,imx7ulp-lpuart";
+ compatible = "fsl,imx93-lpuart", "fsl,imx8ulp-lpuart", "fsl,imx7ulp-lpuart";
reg = <0x42690000 0x1000>;
interrupts = <GIC_SPI 210 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clk IMX93_CLK_LPUART7_GATE>;
@@ -560,7 +560,7 @@
};

lpuart8: serial@426a0000 {
- compatible = "fsl,imx93-lpuart", "fsl,imx7ulp-lpuart";
+ compatible = "fsl,imx93-lpuart", "fsl,imx8ulp-lpuart", "fsl,imx7ulp-lpuart";
reg = <0x426a0000 0x1000>;
interrupts = <GIC_SPI 211 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clk IMX93_CLK_LPUART8_GATE>;
--
2.17.1


2023-07-05 02:25:08

by Sherry Sun

[permalink] [raw]
Subject: [PATCH V4 1/3] arm64: dts: imx8dxl: remove "fsl,imx7ulp-lpuart" compatible for imx8dxl

Drop the i.MX8DXL backwards compatibility with i.MX7ULP since they
differ from clocks handling point of view.

dtbs_check has the following warnings:
linux-next/arch/arm64/boot/dts/freescale/imx8dxl-evk.dtb: serial@5a060000: compatible: 'oneOf' conditional failed, one must be fixed:
['fsl,imx8qxp-lpuart', 'fsl,imx7ulp-lpuart'] is too long
'fsl,imx93-lpuart' was expected
'fsl,imx8qxp-lpuart' is not one of ['fsl,imx8qm-lpuart', 'fsl,imx8dxl-lpuart']
'fsl,imxrt1050-lpuart' was expected
'fsl,imx8ulp-lpuart' was expected
'fsl,imx8qxp-lpuart' was expected
'fsl,imxrt1170-lpuart' was expected
From schema: linux-next/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml

Signed-off-by: Sherry Sun <[email protected]>
---
arch/arm64/boot/dts/freescale/imx8dxl-ss-adma.dtsi | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8dxl-ss-adma.dtsi b/arch/arm64/boot/dts/freescale/imx8dxl-ss-adma.dtsi
index 6881330ab4c6..e2eeddf38aa3 100644
--- a/arch/arm64/boot/dts/freescale/imx8dxl-ss-adma.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8dxl-ss-adma.dtsi
@@ -36,22 +36,22 @@
};

&lpuart0 {
- compatible = "fsl,imx8qxp-lpuart", "fsl,imx7ulp-lpuart";
+ compatible = "fsl,imx8dxl-lpuart", "fsl,imx8qxp-lpuart";
interrupts = <GIC_SPI 228 IRQ_TYPE_LEVEL_HIGH>;
};

&lpuart1 {
- compatible = "fsl,imx8qxp-lpuart", "fsl,imx7ulp-lpuart";
+ compatible = "fsl,imx8dxl-lpuart", "fsl,imx8qxp-lpuart";
interrupts = <GIC_SPI 229 IRQ_TYPE_LEVEL_HIGH>;
};

&lpuart2 {
- compatible = "fsl,imx8qxp-lpuart", "fsl,imx7ulp-lpuart";
+ compatible = "fsl,imx8dxl-lpuart", "fsl,imx8qxp-lpuart";
interrupts = <GIC_SPI 230 IRQ_TYPE_LEVEL_HIGH>;
};

&lpuart3 {
- compatible = "fsl,imx8qxp-lpuart", "fsl,imx7ulp-lpuart";
+ compatible = "fsl,imx8dxl-lpuart", "fsl,imx8qxp-lpuart";
interrupts = <GIC_SPI 231 IRQ_TYPE_LEVEL_HIGH>;
};

--
2.17.1


2023-07-18 03:49:43

by Shawn Guo

[permalink] [raw]
Subject: Re: [PATCH V4 0/3] correct the lpuart compatible for imx8dxl and imx93

On Wed, Jul 05, 2023 at 09:55:59AM +0800, Sherry Sun wrote:
> This patch set corrects the lpuart compatible for imx8dxl and imx93 platforms,
> also correct the corresponding fsl-lpuart dt-binding doc.
>
> ---
> Changes in V4
> 1. add Reviewed-by tag for patch#3
>
> Changes in V3
> 1. remove the redundant fsl,imx8ulp-lpuart entry in patch#3
> 2. change const to enum for better readability in patch#3
>
> Changes in V2
> 1. drop the imx8ulp dts changes in last version patch set
> 2. add both "fsl,imx8ulp-lpuart" and "fsl,imx7ulp-lpuart" for imx93
> 3. correct the dt-bindings for imx93 lpuart compatible
> ---
>
> Sherry Sun (3):
> arm64: dts: imx8dxl: remove "fsl,imx7ulp-lpuart" compatible for
> imx8dxl
> arm64: dts: imx93: add "fsl,imx8ulp-lpuart" compatible for imx93
> dt-bindings: serial: fsl-lpuart: correct imx93-lpuart dt-binding item

I've already picked up two DTS patches from v3. The dt-bindings one
needs to go via serial subsystem tree.

Shawn