2023-07-05 11:09:24

by Minjie Du

Subject: [PATCH v2] RDMA/qedr: Remove a duplicate assignment in qedr_create_gsi_qp()

Delete a duplicate statement from this function implementation.

Signed-off-by: Minjie Du <[email protected]>
---
drivers/infiniband/hw/qedr/qedr_roce_cm.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/infiniband/hw/qedr/qedr_roce_cm.c b/drivers/infiniband/hw/qedr/qedr_roce_cm.c
index 05307c148..859f66a51 100644
--- a/drivers/infiniband/hw/qedr/qedr_roce_cm.c
+++ b/drivers/infiniband/hw/qedr/qedr_roce_cm.c
@@ -354,7 +354,6 @@ int qedr_create_gsi_qp(struct qedr_dev *dev, struct ib_qp_init_attr *attrs,
/* the GSI CQ is handled by the driver so remove it from the FW */
qedr_destroy_gsi_cq(dev, attrs);
dev->gsi_rqcq->cq_type = QEDR_CQ_TYPE_GSI;
- dev->gsi_rqcq->cq_type = QEDR_CQ_TYPE_GSI;

DP_DEBUG(dev, QEDR_MSG_GSI, "created GSI QP %p\n", qp);

--
2.39.0

2023-07-11 06:43:37

by Alok Prasad

Subject: RE: [PATCH v2] RDMA/qedr: Remove a duplicate assignment in qedr_create_gsi_qp()

> -----Original Message-----
> From: Minjie Du <[email protected]>
> Sent: 05 July 2023 16:10
> To: [email protected]; Michal Kalderon <[email protected]>; Ariel Elior <[email protected]>; Jason Gunthorpe
> <[email protected]>; Leon Romanovsky <[email protected]>; open list:QLOGIC QL4xxx RDMA DRIVER <[email protected]>; open
> list <[email protected]>
> Cc: [email protected]; Minjie Du <[email protected]>
> Subject: [PATCH v2] RDMA/qedr: Remove a duplicate assignment in qedr_create_gsi_qp()
>
> Delete a duplicate statement from this function implementation.
>
> Signed-off-by: Minjie Du <[email protected]>
> ---
> drivers/infiniband/hw/qedr/qedr_roce_cm.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/infiniband/hw/qedr/qedr_roce_cm.c b/drivers/infiniband/hw/qedr/qedr_roce_cm.c
> index 05307c148..859f66a51 100644
> --- a/drivers/infiniband/hw/qedr/qedr_roce_cm.c
> +++ b/drivers/infiniband/hw/qedr/qedr_roce_cm.c
> @@ -354,7 +354,6 @@ int qedr_create_gsi_qp(struct qedr_dev *dev, struct ib_qp_init_attr *attrs,
> /* the GSI CQ is handled by the driver so remove it from the FW */
> qedr_destroy_gsi_cq(dev, attrs);
> dev->gsi_rqcq->cq_type = QEDR_CQ_TYPE_GSI;
> - dev->gsi_rqcq->cq_type = QEDR_CQ_TYPE_GSI;
>
> DP_DEBUG(dev, QEDR_MSG_GSI, "created GSI QP %p\n", qp);
>
> --
> 2.39.0


Thanks for making the change.

Acked-by: Alok Prasad <[email protected]>

2023-07-19 10:15:32

by Leon Romanovsky

Subject: Re: [PATCH v2] RDMA/qedr: Remove a duplicate assignment in qedr_create_gsi_qp()

On Wed, 05 Jul 2023 18:39:50 +0800, Minjie Du wrote:
> Delete a duplicate statement from this function implementation.
>
>

Applied, thanks!

[1/1] RDMA/qedr: Remove a duplicate assignment in qedr_create_gsi_qp()
https://git.kernel.org/rdma/rdma/c/296609e6b64cd1

Best regards,
--
Leon Romanovsky <[email protected]>