Delete a duplicate statement from this function implementation.
Signed-off-by: Minjie Du <[email protected]>
---
arch/m68k/apollo/config.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/m68k/apollo/config.c b/arch/m68k/apollo/config.c
index 42a8b8e2b..5645d2018 100644
--- a/arch/m68k/apollo/config.c
+++ b/arch/m68k/apollo/config.c
@@ -173,7 +173,6 @@ irqreturn_t dn_timer_int(int irq, void *dev_id)
legacy_timer_tick(1);
timer_heartbeat();
- x = *(volatile unsigned char *)(apollo_timer + 3);
x = *(volatile unsigned char *)(apollo_timer + 5);
return IRQ_HANDLED;
--
2.39.0
Hi Minjie,
On Wed, Jul 5, 2023 at 2:13 PM Minjie Du <[email protected]> wrote:
> Delete a duplicate statement from this function implementation.
>
> Signed-off-by: Minjie Du <[email protected]>
Thanks for your patch, which is presumably untested on real hardware?
> --- a/arch/m68k/apollo/config.c
> +++ b/arch/m68k/apollo/config.c
> @@ -173,7 +173,6 @@ irqreturn_t dn_timer_int(int irq, void *dev_id)
> legacy_timer_tick(1);
> timer_heartbeat();
>
> - x = *(volatile unsigned char *)(apollo_timer + 3);
> x = *(volatile unsigned char *)(apollo_timer + 5);
This is intentional: the use of volatile makes sure the registers at
offsets 3 and 5 are read, in that order.
I agree this could be made more obvious by converting the code to the
more modern READ_ONCE() helper.
But please do not send such a patch without testing.
>
> return IRQ_HANDLED;
NAKed-by: Geert Uytterhoeven <[email protected]>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
On Jul 05 2023, Minjie Du wrote:
> Delete a duplicate statement from this function implementation.
>
> Signed-off-by: Minjie Du <[email protected]>
> ---
> arch/m68k/apollo/config.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/m68k/apollo/config.c b/arch/m68k/apollo/config.c
> index 42a8b8e2b..5645d2018 100644
> --- a/arch/m68k/apollo/config.c
> +++ b/arch/m68k/apollo/config.c
> @@ -173,7 +173,6 @@ irqreturn_t dn_timer_int(int irq, void *dev_id)
> legacy_timer_tick(1);
> timer_heartbeat();
>
> - x = *(volatile unsigned char *)(apollo_timer + 3);
> x = *(volatile unsigned char *)(apollo_timer + 5);
They are not the same: 3 != 5.
--
Andreas Schwab, [email protected]
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."