2023-07-06 07:39:11

by Minjie Du

Subject: [PATCH v1] virt: kvm: Replace define function

Replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE.

Signed-off-by: Minjie Du <[email protected]>
---
virt/kvm/kvm_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
index dfbaafbe3..ec1fabfbd 100644
--- a/virt/kvm/kvm_main.c
+++ b/virt/kvm/kvm_main.c
@@ -3880,7 +3880,7 @@ static int vcpu_get_pid(void *data, u64 *val)
return 0;
}

-DEFINE_SIMPLE_ATTRIBUTE(vcpu_get_pid_fops, vcpu_get_pid, NULL, "%llu\n");
+DEFINE_DEBUGFS_ATTRIBUTE(vcpu_get_pid_fops, vcpu_get_pid, NULL, "%llu\n");

static void kvm_create_vcpu_debugfs(struct kvm_vcpu *vcpu)
{
--
2.39.0

2023-07-10 16:59:29

by Sean Christopherson

Subject: Re: [PATCH v1] virt: kvm: Replace define function

On Thu, Jul 06, 2023, Minjie Du wrote:
> Replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE.

NAK. I'm sending a patch to revert 5103068eaca2 ("debugfs, coccinelle: check for
obsolete DEFINE_SIMPLE_ATTRIBUTE() usage"), this is beyond ridiculous.

https://lore.kernel.org/all/[email protected]