2023-07-06 10:02:32

by Luke D. Jones

Subject: [PATCH] ALSA: hda/realtek: Add quirk for ASUS ROG GZ301V

Adds the required quirk to enable the Cirrus amp and correct pins
on the ASUS ROG GZ301V series which uses an SPI connected Cirrus amp.

While this works if the related _DSD properties are made available, these
aren't included in the ACPI of these laptops (yet).

Signed-off-by: Luke D. Jones <[email protected]>
---
Makefile | 2 +-
sound/pci/hda/patch_realtek.c | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index 12579666581f..e2cae6cc7574 100644
--- a/Makefile
+++ b/Makefile
@@ -2,7 +2,7 @@
VERSION = 6
PATCHLEVEL = 4
SUBLEVEL = 0
-EXTRAVERSION =
+EXTRAVERSION = .rog
NAME = Hurr durr I'ma ninja sloth

# *DOCUMENTATION*
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 1547c40dc7e9..969eb0736bca 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -9607,6 +9607,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x1043, 0x1483, "ASUS GU603V", ALC285_FIXUP_ASUS_HEADSET_MIC),
SND_PCI_QUIRK(0x1043, 0x1493, "ASUS GV601V", ALC285_FIXUP_ASUS_HEADSET_MIC),
SND_PCI_QUIRK(0x1043, 0x1517, "Asus Zenbook UX31A", ALC269VB_FIXUP_ASUS_ZENBOOK_UX31A),
+ SND_PCI_QUIRK(0x1043, 0x1573, "ASUS GZ301V", ALC285_FIXUP_ASUS_HEADSET_MIC),
SND_PCI_QUIRK(0x1043, 0x1662, "ASUS GV301QH", ALC294_FIXUP_ASUS_DUAL_SPK),
SND_PCI_QUIRK(0x1043, 0x1683, "ASUS UM3402YAR", ALC287_FIXUP_CS35L41_I2C_2),
SND_PCI_QUIRK(0x1043, 0x16b2, "ASUS GU603", ALC289_FIXUP_ASUS_GA401),
--
2.41.0

2023-07-06 10:24:15

by Takashi Iwai

Subject: Re: [PATCH] ALSA: hda/realtek: Add quirk for ASUS ROG GZ301V

On Thu, 06 Jul 2023 11:14:47 +0200,
Luke D. Jones wrote:
> diff --git a/Makefile b/Makefile
> index 12579666581f..e2cae6cc7574 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -2,7 +2,7 @@
> VERSION = 6
> PATCHLEVEL = 4
> SUBLEVEL = 0
> -EXTRAVERSION =
> +EXTRAVERSION = .rog
> NAME = Hurr durr I'ma ninja sloth
>
> # *DOCUMENTATION*

Obviously this is wrong for upstreaming.
Please take a look at the patch before the submission at the next time :)


Takashi

2023-07-06 22:22:13

by Luke D. Jones

Subject: Re: [PATCH] ALSA: hda/realtek: Add quirk for ASUS ROG GZ301V

On Thu, 2023-07-06 at 11:45 +0200, Takashi Iwai wrote:
> On Thu, 06 Jul 2023 11:14:47 +0200,
> Luke D. Jones wrote:
> > diff --git a/Makefile b/Makefile
> > index 12579666581f..e2cae6cc7574 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -2,7 +2,7 @@
> >  VERSION = 6
> >  PATCHLEVEL = 4
> >  SUBLEVEL = 0
> > -EXTRAVERSION =
> > +EXTRAVERSION = .rog
> >  NAME = Hurr durr I'ma ninja sloth
> >  
> >  # *DOCUMENTATION*
>
> Obviously this is wrong for upstreaming.
> Please take a look at the patch before the submission at the next
> time :)

Oh, sorry mate. It's been a very tough week. :(