2023-07-06 12:10:42

by Rick Wertenbroek

Subject: [PATCH] docs: scheduler: completion: Fix minor error in pseudo-code

Add missing address-of (&) operator in pseudo-code.

Signed-off-by: Rick Wertenbroek <[email protected]>
---
Documentation/scheduler/completion.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/scheduler/completion.rst b/Documentation/scheduler/completion.rst
index 9f039b4f4b09..f19aca2062bd 100644
--- a/Documentation/scheduler/completion.rst
+++ b/Documentation/scheduler/completion.rst
@@ -157,7 +157,7 @@ A typical usage scenario is::

/* run non-dependent code */ /* do setup */

- wait_for_completion(&setup_done); complete(setup_done);
+ wait_for_completion(&setup_done); complete(&setup_done);

This is not implying any particular order between wait_for_completion() and
the call to complete() - if the call to complete() happened before the call
--
2.25.1

2023-07-14 19:47:45

by Jonathan Corbet

Subject: Re: [PATCH] docs: scheduler: completion: Fix minor error in pseudo-code

Rick Wertenbroek <[email protected]> writes:

> Add missing address-of (&) operator in pseudo-code.
>
> Signed-off-by: Rick Wertenbroek <[email protected]>
> ---
> Documentation/scheduler/completion.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/scheduler/completion.rst b/Documentation/scheduler/completion.rst
> index 9f039b4f4b09..f19aca2062bd 100644
> --- a/Documentation/scheduler/completion.rst
> +++ b/Documentation/scheduler/completion.rst
> @@ -157,7 +157,7 @@ A typical usage scenario is::
>
> /* run non-dependent code */ /* do setup */
>
> - wait_for_completion(&setup_done); complete(setup_done);
> + wait_for_completion(&setup_done); complete(&setup_done);
>

Applied, thanks.

jon