2023-07-06 13:26:16

by Christian Göttsche

Subject: [RFC PATCH 18/20] selinux: nlmsgtab: implicit conversion

Use an unsigned type as loop iterator.

Signed-off-by: Christian Göttsche <[email protected]>
---
security/selinux/nlmsgtab.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/security/selinux/nlmsgtab.c b/security/selinux/nlmsgtab.c
index 2ee7b4ed43ef..b36623d5cf11 100644
--- a/security/selinux/nlmsgtab.c
+++ b/security/selinux/nlmsgtab.c
@@ -153,9 +153,9 @@ static const struct nlmsg_perm nlmsg_audit_perms[] = {

static int nlmsg_perm(u16 nlmsg_type, u32 *perm, const struct nlmsg_perm *tab, size_t tabsize)
{
- int i, err = -EINVAL;
+ int err = -EINVAL;

- for (i = 0; i < tabsize/sizeof(struct nlmsg_perm); i++)
+ for (u32 i = 0; i < tabsize/sizeof(struct nlmsg_perm); i++)
if (nlmsg_type == tab[i].nlmsg_type) {
*perm = tab[i].perm;
err = 0;
--
2.40.1

2023-07-18 22:04:03

by Paul Moore

Subject: Re: [PATCH RFC 18/20] selinux: nlmsgtab: implicit conversion

On Jul 6, 2023 =?UTF-8?q?Christian=20G=C3=B6ttsche?= <[email protected]> wrote:
>
> Use an unsigned type as loop iterator.
>
> Signed-off-by: Christian Göttsche <[email protected]>
> ---
> security/selinux/nlmsgtab.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

Loop iterators ...

--
paul-moore.com