2023-07-07 08:35:53

by Neil Armstrong

Subject: [PATCH v2 0/2] dt-bindings: pinctrl: amlogic,meson-pinctrl-common: add missing properties

The amlogic DT uses gpio-line-names and gpio-hog, add those
to the yaml converted pinctrl bindings.

This will fix the following dtschema check errors:
arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dtb: pinctrl@40: bank@40: Unevaluated properties are not allowed ('gpio-line-names', 'usb-hub-hog' were unexpected)
arch/arm64/boot/dts/amlogic/meson-gxbb-nanopi-k2.dtb: pinctrl@4b0: bank@4b0: Unevaluated properties are not allowed ('gpio-line-names' was unexpected)
..

Signed-off-by: Neil Armstrong <[email protected]>
---
Changes in v2:
- Added review tags
- Moved line-names out of common and added min/max items for each bindings
- Link to v1: https://lore.kernel.org/r/20230706-topic-amlogic-upstream-pinctrl-fix-bindings-v1-0-fa442d5aae91@linaro.org

---
Neil Armstrong (2):
dt-bindings: pinctrl: amlogic,meson-pinctrl: allow gpio-line-names
dt-bindings: pinctrl: amlogic,meson-pinctrl-common: allow gpio hogs

.../devicetree/bindings/pinctrl/amlogic,meson-pinctrl-a1.yaml | 4 ++++
.../devicetree/bindings/pinctrl/amlogic,meson-pinctrl-common.yaml | 7 +++++++
.../bindings/pinctrl/amlogic,meson-pinctrl-g12a-aobus.yaml | 3 +++
.../bindings/pinctrl/amlogic,meson-pinctrl-g12a-periphs.yaml | 3 +++
.../devicetree/bindings/pinctrl/amlogic,meson8-pinctrl-aobus.yaml | 4 ++++
.../devicetree/bindings/pinctrl/amlogic,meson8-pinctrl-cbus.yaml | 4 ++++
6 files changed, 25 insertions(+)
---
base-commit: e1f6a8eaf1c271a0158114a03e3605f4fba059ad
change-id: 20230706-topic-amlogic-upstream-pinctrl-fix-bindings-c2b74c637872

Best regards,
--
Neil Armstrong <[email protected]>

2023-07-07 08:36:51

by Neil Armstrong

Subject: [PATCH v2 2/2] dt-bindings: pinctrl: amlogic,meson-pinctrl-common: allow gpio hogs

Allow gpio hog subnodes to the gpio subnode.

Fixes: 94df03a45276 ("dt-bindings: pinctrl: Convert Amlogic Meson pinctrl binding")
Reviewed-by: Rob Herring <[email protected]>
Signed-off-by: Neil Armstrong <[email protected]>
---
.../devicetree/bindings/pinctrl/amlogic,meson-pinctrl-common.yaml | 7 +++++++
1 file changed, 7 insertions(+)

diff --git a/Documentation/devicetree/bindings/pinctrl/amlogic,meson-pinctrl-common.yaml b/Documentation/devicetree/bindings/pinctrl/amlogic,meson-pinctrl-common.yaml
index a7b29ef0bab6..e707c222a07f 100644
--- a/Documentation/devicetree/bindings/pinctrl/amlogic,meson-pinctrl-common.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/amlogic,meson-pinctrl-common.yaml
@@ -41,6 +41,13 @@ $defs:
gpio-ranges:
maxItems: 1

+ patternProperties:
+ "^.+-hog(-[0-9]+)?$":
+ type: object
+
+ required:
+ - gpio-hog
+
required:
- reg
- reg-names

--
2.34.1

2023-07-16 21:54:19

by Linus Walleij

Subject: Re: [PATCH v2 0/2] dt-bindings: pinctrl: amlogic,meson-pinctrl-common: add missing properties

On Fri, Jul 7, 2023 at 10:20 AM Neil Armstrong
<[email protected]> wrote:

> The amlogic DT uses gpio-line-names and gpio-hog, add those
> to the yaml converted pinctrl bindings.
>
> This will fix the following dtschema check errors:
> arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dtb: pinctrl@40: bank@40: Unevaluated properties are not allowed ('gpio-line-names', 'usb-hub-hog' were unexpected)
> arch/arm64/boot/dts/amlogic/meson-gxbb-nanopi-k2.dtb: pinctrl@4b0: bank@4b0: Unevaluated properties are not allowed ('gpio-line-names' was unexpected)

Patches applied, thanks for attention to detail!

Yours,
Linus Walleij