2023-07-07 10:13:48

by Chengming Zhou

Subject: [PATCH v3 1/4] blk-mq: delete unused completion_data in struct request

From: Chengming Zhou <[email protected]>

After global search, I found "completion_data" in struct request
is not used anywhere, so just clean it up by the way.

Signed-off-by: Chengming Zhou <[email protected]>
Reviewed-by: Christoph Hellwig <[email protected]>
---
include/linux/blk-mq.h | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/include/linux/blk-mq.h b/include/linux/blk-mq.h
index f401067ac03a..0a1c404e6c7a 100644
--- a/include/linux/blk-mq.h
+++ b/include/linux/blk-mq.h
@@ -158,13 +158,11 @@ struct request {

/*
* The rb_node is only used inside the io scheduler, requests
- * are pruned when moved to the dispatch queue. So let the
- * completion_data share space with the rb_node.
+ * are pruned when moved to the dispatch queue.
*/
union {
struct rb_node rb_node; /* sort/lookup */
struct bio_vec special_vec;
- void *completion_data;
};

/*
--
2.41.0

2023-07-07 10:31:50

by Ming Lei

Subject: Re: [PATCH v3 1/4] blk-mq: delete unused completion_data in struct request

On Fri, Jul 07, 2023 at 05:37:19PM +0800, [email protected] wrote:
> From: Chengming Zhou <[email protected]>
>
> After global search, I found "completion_data" in struct request
> is not used anywhere, so just clean it up by the way.
>
> Signed-off-by: Chengming Zhou <[email protected]>
> Reviewed-by: Christoph Hellwig <[email protected]>

Reviewed-by: Ming Lei <[email protected]>

Thanks,
Ming