From: George Stark <[email protected]>
Changelog:
v1->v2:
split refactoring patch [1] into 4 smaller patches, fix comment style
[1] https://lore.kernel.org/lkml/[email protected]/
v2->v3:
remove patch 'meson saradc: unite iio channel array definitions' [1] after discussion
patch 'meson saradc: add enum for iio channel array indexes'
- change enum items prefix from INDEX_ to NUM_ since name 'channel index' is
more relevant to channel array index in iio world and with 2 tables our array index is
not always equal to channel number
- resolve conflicts after deleting [1]
- update commit message, previous patch [2]
- return channel number for temp channel. It wasn't used and isn't used currently
but may need later
patch meson saradc: support reading from channel 7 mux inputs
- resolve conflicts after deleting [1]
- update commit message, previous patch [3]
- add routine find_channel_by_num to get channel by channel number
[1] https://lore.kernel.org/lkml/[email protected]/
[2] https://lore.kernel.org/lkml/[email protected]/
[3] https://lore.kernel.org/lkml/[email protected]/
v3->v4:
add new patch 'iio: adc: meson: remove unused timestamp channel' [1]
patch 'iio: adc: meson: move enums declaration before'
update commit message, previous patch [2]
patch 'iio: adc: meson: move meson_sar_adc_set_chan7_mux'
update commit message, previous patch [3]
patch 'iio: adc: meson: add enum for iio channel numbers'
update commit message, previous patch [4]
patch 'iio: adc: meson: add channel labels'
update commit message, previous patch [5]
change sprintf(label, "%s\n", "temp-sensor") to sprintf(label, "temp-sensor\n")
patch 'iio: adc: meson: support reading from channel 7 mux'
rewrite enum meson_sar_adc_chan7_mux_sel definition and
read_label routine proposed by Andy [7], previous patch [6]
[1] https://lore.kernel.org/lkml/[email protected]/
[2] https://lore.kernel.org/lkml/[email protected]/
[3] https://lore.kernel.org/lkml/[email protected]/
[4] https://lore.kernel.org/lkml/[email protected]/
[5] https://lore.kernel.org/lkml/[email protected]/
[6] https://lore.kernel.org/lkml/[email protected]/
[7] https://lore.kernel.org/lkml/[email protected]/
George Stark (6):
iio: adc: meson: remove unused timestamp channel
iio: adc: meson: move enums declaration before variables declaration
iio: adc: meson: move meson_sar_adc_set_chan7_mux routine upper
iio: adc: meson: add enum for iio channel numbers
iio: adc: meson: add channel labels
iio: adc: meson: support reading from channel 7 mux inputs
drivers/iio/adc/meson_saradc.c | 173 +++++++++++++++++++++++++--------
1 file changed, 134 insertions(+), 39 deletions(-)
--
2.38.4
On Fri, 7 Jul 2023 18:27:37 +0300
George Stark <[email protected]> wrote:
> From: George Stark <[email protected]>
All looks fine to me. However, given earlier versions had various other reviewers
I'd like to leave it on list a little longer.
Jonathan
>
> Changelog:
>
> v1->v2:
> split refactoring patch [1] into 4 smaller patches, fix comment style
>
> [1] https://lore.kernel.org/lkml/[email protected]/
>
> v2->v3:
> remove patch 'meson saradc: unite iio channel array definitions' [1] after discussion
>
> patch 'meson saradc: add enum for iio channel array indexes'
> - change enum items prefix from INDEX_ to NUM_ since name 'channel index' is
> more relevant to channel array index in iio world and with 2 tables our array index is
> not always equal to channel number
> - resolve conflicts after deleting [1]
> - update commit message, previous patch [2]
> - return channel number for temp channel. It wasn't used and isn't used currently
> but may need later
>
> patch meson saradc: support reading from channel 7 mux inputs
> - resolve conflicts after deleting [1]
> - update commit message, previous patch [3]
> - add routine find_channel_by_num to get channel by channel number
>
> [1] https://lore.kernel.org/lkml/[email protected]/
> [2] https://lore.kernel.org/lkml/[email protected]/
> [3] https://lore.kernel.org/lkml/[email protected]/
>
> v3->v4:
> add new patch 'iio: adc: meson: remove unused timestamp channel' [1]
>
> patch 'iio: adc: meson: move enums declaration before'
> update commit message, previous patch [2]
> patch 'iio: adc: meson: move meson_sar_adc_set_chan7_mux'
> update commit message, previous patch [3]
> patch 'iio: adc: meson: add enum for iio channel numbers'
> update commit message, previous patch [4]
> patch 'iio: adc: meson: add channel labels'
> update commit message, previous patch [5]
> change sprintf(label, "%s\n", "temp-sensor") to sprintf(label, "temp-sensor\n")
> patch 'iio: adc: meson: support reading from channel 7 mux'
> rewrite enum meson_sar_adc_chan7_mux_sel definition and
> read_label routine proposed by Andy [7], previous patch [6]
>
> [1] https://lore.kernel.org/lkml/[email protected]/
> [2] https://lore.kernel.org/lkml/[email protected]/
> [3] https://lore.kernel.org/lkml/[email protected]/
> [4] https://lore.kernel.org/lkml/[email protected]/
> [5] https://lore.kernel.org/lkml/[email protected]/
> [6] https://lore.kernel.org/lkml/[email protected]/
> [7] https://lore.kernel.org/lkml/[email protected]/
>
> George Stark (6):
> iio: adc: meson: remove unused timestamp channel
> iio: adc: meson: move enums declaration before variables declaration
> iio: adc: meson: move meson_sar_adc_set_chan7_mux routine upper
> iio: adc: meson: add enum for iio channel numbers
> iio: adc: meson: add channel labels
> iio: adc: meson: support reading from channel 7 mux inputs
>
> drivers/iio/adc/meson_saradc.c | 173 +++++++++++++++++++++++++--------
> 1 file changed, 134 insertions(+), 39 deletions(-)
>
On Sat, Jul 08, 2023 at 05:04:10PM +0100, Jonathan Cameron wrote:
> On Fri, 7 Jul 2023 18:27:37 +0300
> George Stark <[email protected]> wrote:
>
> > From: George Stark <[email protected]>
>
>
> All looks fine to me. However, given earlier versions had various other reviewers
> I'd like to leave it on list a little longer.
Code wise
Reviewed-by: Andy Shevchenko <[email protected]>
The commit messages have to be improved, but hey, I'm not a native speaker, so
I assume that Jonathan can help me with that and correct me if required :-)
--
With Best Regards,
Andy Shevchenko