2023-07-10 02:53:06

by 李扬韬

Subject: [PATCH v3 05/11] ata: sata_rcar: drop useless initializer

There is no need to initialize the variable ret.

Signed-off-by: Yangtao Li <[email protected]>
Reviewed-by: Sergey Shtylyov <[email protected]>
---
drivers/ata/sata_rcar.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/ata/sata_rcar.c b/drivers/ata/sata_rcar.c
index 34790f15c1b8..f299b41ab3e6 100644
--- a/drivers/ata/sata_rcar.c
+++ b/drivers/ata/sata_rcar.c
@@ -862,8 +862,7 @@ static int sata_rcar_probe(struct platform_device *pdev)
struct ata_host *host;
struct sata_rcar_priv *priv;
struct resource *mem;
- int irq;
- int ret = 0;
+ int irq, ret;

irq = platform_get_irq(pdev, 0);
if (irq < 0)
--
2.39.0

2023-07-10 12:55:28

by Geert Uytterhoeven

Subject: Re: [PATCH v3 05/11] ata: sata_rcar: drop useless initializer

On Mon, Jul 10, 2023 at 4:47 AM Yangtao Li <[email protected]> wrote:
> There is no need to initialize the variable ret.
>
> Signed-off-by: Yangtao Li <[email protected]>
> Reviewed-by: Sergey Shtylyov <[email protected]>

Reviewed-by: Geert Uytterhoeven <[email protected]>

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds