2023-07-10 23:33:04

by Bjorn Helgaas

Subject: [PATCH] cxl/pci: Remove unnecessary aer.h include

From: Bjorn Helgaas <[email protected]>

<linux/aer.h> is unused, so remove it.

Signed-off-by: Bjorn Helgaas <[email protected]>
Reviewed-by: Ira Weiny <[email protected]>
Cc: Alison Schofield <[email protected]>
Cc: Vishal Verma <[email protected]>
Cc: Ben Widawsky <[email protected]>
Cc: Dan Williams <[email protected]>
---
drivers/cxl/pci.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/cxl/pci.c b/drivers/cxl/pci.c
index 1cb1494c28fe..8314cf2ac16a 100644
--- a/drivers/cxl/pci.c
+++ b/drivers/cxl/pci.c
@@ -8,7 +8,6 @@
#include <linux/mutex.h>
#include <linux/list.h>
#include <linux/pci.h>
-#include <linux/aer.h>
#include <linux/io.h>
#include "cxlmem.h"
#include "cxlpci.h"
--
2.34.1

2023-07-11 08:22:39

by Jonathan Cameron

Subject: Re: [PATCH] cxl/pci: Remove unnecessary aer.h include

On Mon, 10 Jul 2023 18:14:16 -0500
Bjorn Helgaas <[email protected]> wrote:

> From: Bjorn Helgaas <[email protected]>
>
> <linux/aer.h> is unused, so remove it.
>
> Signed-off-by: Bjorn Helgaas <[email protected]>
> Reviewed-by: Ira Weiny <[email protected]>
> Cc: Alison Schofield <[email protected]>
> Cc: Vishal Verma <[email protected]>
> Cc: Ben Widawsky <[email protected]>
> Cc: Dan Williams <[email protected]>
Was just working on splitting this file up as part of forward porting
the switch-cci and noticed this as well!

Lot of churn in this file in the recent past and I'll make it worse,
so good to keep on top of these includes.

Reviewed-by: Jonathan Cameron <[email protected]>

> ---
> drivers/cxl/pci.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/cxl/pci.c b/drivers/cxl/pci.c
> index 1cb1494c28fe..8314cf2ac16a 100644
> --- a/drivers/cxl/pci.c
> +++ b/drivers/cxl/pci.c
> @@ -8,7 +8,6 @@
> #include <linux/mutex.h>
> #include <linux/list.h>
> #include <linux/pci.h>
> -#include <linux/aer.h>
> #include <linux/io.h>
> #include "cxlmem.h"
> #include "cxlpci.h"

2023-07-12 16:29:39

by Dave Jiang

Subject: Re: [PATCH] cxl/pci: Remove unnecessary aer.h include

On 7/10/23 16:14, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <[email protected]>
>
> <linux/aer.h> is unused, so remove it.
>
> Signed-off-by: Bjorn Helgaas <[email protected]>
> Reviewed-by: Ira Weiny <[email protected]>
> Cc: Alison Schofield <[email protected]>
> Cc: Vishal Verma <[email protected]>
> Cc: Ben Widawsky <[email protected]>
> Cc: Dan Williams <[email protected]>

Reviewed-by: Dave Jiang <[email protected]>
> ---
> drivers/cxl/pci.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/cxl/pci.c b/drivers/cxl/pci.c
> index 1cb1494c28fe..8314cf2ac16a 100644
> --- a/drivers/cxl/pci.c
> +++ b/drivers/cxl/pci.c
> @@ -8,7 +8,6 @@
> #include <linux/mutex.h>
> #include <linux/list.h>
> #include <linux/pci.h>
> -#include <linux/aer.h>
> #include <linux/io.h>
> #include "cxlmem.h"
> #include "cxlpci.h"