2023-07-11 02:59:26

by Jason-ch Chen

[permalink] [raw]
Subject: [PATCH v2 3/4] dt-bindings: soc: mediatek: pwrap: Add compatible for MT8188

From: jason-ch chen <[email protected]>

Add MT8188 PMIC Wrapper compatible to binding document.

Signed-off-by: jason-ch chen <[email protected]>
---
.../devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml b/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
index a06ac2177444..c2f22e7dbcfb 100644
--- a/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
+++ b/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
@@ -50,6 +50,11 @@ properties:
- mediatek,mt8186-pwrap
- mediatek,mt8195-pwrap
- const: syscon
+ - items:
+ - enum:
+ - mediatek,mt8188-pwrap
+ - const: mediatek,mt8195-pwrap
+ - const: syscon

reg:
minItems: 1
--
2.18.0



2023-07-11 06:23:31

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v2 3/4] dt-bindings: soc: mediatek: pwrap: Add compatible for MT8188

On 11/07/2023 04:39, Jason-ch Chen wrote:
> From: jason-ch chen <[email protected]>
>
> Add MT8188 PMIC Wrapper compatible to binding document.
>
> Signed-off-by: jason-ch chen <[email protected]>
> ---
> .../devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml b/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
> index a06ac2177444..c2f22e7dbcfb 100644
> --- a/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
> +++ b/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
> @@ -50,6 +50,11 @@ properties:
> - mediatek,mt8186-pwrap
> - mediatek,mt8195-pwrap
> - const: syscon
> + - items:
> + - enum:
> + - mediatek,mt8188-pwrap

Why do you add duplicated entries? Test your DTS before sending patches.


Best regards,
Krzysztof


2023-07-11 18:58:05

by Conor Dooley

[permalink] [raw]
Subject: Re: [PATCH v2 3/4] dt-bindings: soc: mediatek: pwrap: Add compatible for MT8188

On Tue, Jul 11, 2023 at 10:39:28AM +0800, Jason-ch Chen wrote:
> From: jason-ch chen <[email protected]>
>
> Add MT8188 PMIC Wrapper compatible to binding document.
>
> Signed-off-by: jason-ch chen <[email protected]>

Acked-by: Conor Dooley <[email protected]>

Cheers,
Conor.

> ---
> .../devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml b/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
> index a06ac2177444..c2f22e7dbcfb 100644
> --- a/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
> +++ b/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
> @@ -50,6 +50,11 @@ properties:
> - mediatek,mt8186-pwrap
> - mediatek,mt8195-pwrap
> - const: syscon
> + - items:
> + - enum:
> + - mediatek,mt8188-pwrap
> + - const: mediatek,mt8195-pwrap
> + - const: syscon
>
> reg:
> minItems: 1
> --
> 2.18.0
>

Attachments:
(No filename) (1.12 kB)
 signature.asc (235.00 B)
 Download all attachments

2023-07-17 12:12:56

by Jason-ch Chen

[permalink] [raw]
Subject: Re: [PATCH v2 3/4] dt-bindings: soc: mediatek: pwrap: Add compatible for MT8188

Hi Krzysztof,

On Tue, 2023-07-11 at 08:07 +0200, Krzysztof Kozlowski wrote:
>
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> On 11/07/2023 04:39, Jason-ch Chen wrote:
> > From: jason-ch chen <[email protected]>
> >
> > Add MT8188 PMIC Wrapper compatible to binding document.
> >
> > Signed-off-by: jason-ch chen <[email protected]>
> > ---
> > .../devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml | 5
> +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git
> a/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
> b/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
> > index a06ac2177444..c2f22e7dbcfb 100644
> > ---
> a/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
> > +++
> b/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
> > @@ -50,6 +50,11 @@ properties:
> > - mediatek,mt8186-pwrap
> > - mediatek,mt8195-pwrap
> > - const: syscon
> > + - items:
> > + - enum:
> > + - mediatek,mt8188-pwrap
>
> Why do you add duplicated entries? Test your DTS before sending
> patches.
In the next patch, I will remove the duplicated part. Thank you.

>
>
> Best regards,
> Krzysztof
>