2023-07-11 07:23:55

by Krzysztof Kozlowski

Subject: [PATCH] arm64: dts: qcom: sm8250-sony-xperia: correct GPIO keys wakeup again

gpio-keys,wakeup is a deprecated property:

m8250-sony-xperia-edo-pdx206.dtb: gpio-keys: key-camera-focus: Unevaluated properties are not allowed ('gpio-key,wakeup' was unexpected)

Fixes: a422c6a91a66 ("arm64: dts: qcom: sm8250-edo: Rectify gpio-keys")
Signed-off-by: Krzysztof Kozlowski <[email protected]>

---

It's a damn Groundhog day. I already fixed all the occurences in
77a7e3942871 ("arm64: dts: qcom: sm8250-sony-xperia: correct GPIO keys
wakeup")!
---
arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi b/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi
index cd27794739a5..ecdc20bc10f5 100644
--- a/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi
@@ -60,7 +60,7 @@ key-camera-focus {
gpios = <&pm8150b_gpios 2 GPIO_ACTIVE_LOW>;
debounce-interval = <15>;
linux,can-disable;
- gpio-key,wakeup;
+ wakeup-source;
};

key-camera-snapshot {
@@ -69,7 +69,7 @@ key-camera-snapshot {
gpios = <&pm8150b_gpios 1 GPIO_ACTIVE_LOW>;
debounce-interval = <15>;
linux,can-disable;
- gpio-key,wakeup;
+ wakeup-source;
};

key-vol-down {
--
2.34.1

2023-07-11 11:57:41

by Konrad Dybcio

Subject: Re: [PATCH] arm64: dts: qcom: sm8250-sony-xperia: correct GPIO keys wakeup again

On 11.07.2023 08:30, Krzysztof Kozlowski wrote:
> gpio-keys,wakeup is a deprecated property:
>
> m8250-sony-xperia-edo-pdx206.dtb: gpio-keys: key-camera-focus: Unevaluated properties are not allowed ('gpio-key,wakeup' was unexpected)
>
> Fixes: a422c6a91a66 ("arm64: dts: qcom: sm8250-edo: Rectify gpio-keys")
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>
> ---
>
> It's a damn Groundhog day. I already fixed all the occurences in
> 77a7e3942871 ("arm64: dts: qcom: sm8250-sony-xperia: correct GPIO keys
> wakeup")!
> ---
Sorry.. this was an old lingering patch that I failed to retest.

Reviewed-by: Konrad Dybcio <[email protected]>

Konrad
> arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi b/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi
> index cd27794739a5..ecdc20bc10f5 100644
> --- a/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi
> @@ -60,7 +60,7 @@ key-camera-focus {
> gpios = <&pm8150b_gpios 2 GPIO_ACTIVE_LOW>;
> debounce-interval = <15>;
> linux,can-disable;
> - gpio-key,wakeup;
> + wakeup-source;
> };
>
> key-camera-snapshot {
> @@ -69,7 +69,7 @@ key-camera-snapshot {
> gpios = <&pm8150b_gpios 1 GPIO_ACTIVE_LOW>;
> debounce-interval = <15>;
> linux,can-disable;
> - gpio-key,wakeup;
> + wakeup-source;
> };
>
> key-vol-down {

2023-07-14 05:32:53

by Bjorn Andersson

Subject: Re: [PATCH] arm64: dts: qcom: sm8250-sony-xperia: correct GPIO keys wakeup again

On Tue, 11 Jul 2023 08:30:11 +0200, Krzysztof Kozlowski wrote:
> gpio-keys,wakeup is a deprecated property:
>
> m8250-sony-xperia-edo-pdx206.dtb: gpio-keys: key-camera-focus: Unevaluated properties are not allowed ('gpio-key,wakeup' was unexpected)
>
>

Applied, thanks!

[1/1] arm64: dts: qcom: sm8250-sony-xperia: correct GPIO keys wakeup again
commit: b8fbeea0253211d97c579eae787274633d3eaf0d

Best regards,
--
Bjorn Andersson <[email protected]>