Use the negated -EINVAL as the error code.
Fixes: 95138e01275e ("leds: pwm: Make error handling more robust")
Signed-off-by: Fei Shao <[email protected]>
---
drivers/leds/leds-pwm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/leds/leds-pwm.c b/drivers/leds/leds-pwm.c
index 29194cc382af..87c199242f3c 100644
--- a/drivers/leds/leds-pwm.c
+++ b/drivers/leds/leds-pwm.c
@@ -146,7 +146,7 @@ static int led_pwm_create_fwnode(struct device *dev, struct led_pwm_priv *priv)
led.name = to_of_node(fwnode)->name;
if (!led.name) {
- ret = EINVAL;
+ ret = -EINVAL;
goto err_child_out;
}
--
2.41.0.390.g38632f3daf-goog
On Tue, Jul 11, 2023 at 11:31 AM Fei Shao <[email protected]> wrote:
>
> Use the negated -EINVAL as the error code.
Thank you, it seems Dan had been the first one.
Message ID <[email protected]>
--
With Best Regards,
Andy Shevchenko
Hi Andy,
On Tue, Jul 11, 2023 at 5:10 PM Andy Shevchenko
<[email protected]> wrote:
>
> On Tue, Jul 11, 2023 at 11:31 AM Fei Shao <[email protected]> wrote:
> >
> > Use the negated -EINVAL as the error code.
>
> Thank you, it seems Dan had been the first one.
>
> Message ID <[email protected]>
Thanks for the pointer. Please disregard this patch.
Regards,
Fei
>
> --
> With Best Regards,
> Andy Shevchenko
On Tue, 11 Jul 2023, Andy Shevchenko wrote:
> On Tue, Jul 11, 2023 at 11:31 AM Fei Shao <[email protected]> wrote:
> >
> > Use the negated -EINVAL as the error code.
>
> Thank you, it seems Dan had been the first one.
>
> Message ID <[email protected]>
I don't know much about how other people operate, but I have no way to
trivially navigate to this. Would you be kind enough to use URLs
please?
--
Lee Jones [李琼斯]
On Wed, Jul 12, 2023 at 3:00 PM Lee Jones <[email protected]> wrote:
> On Tue, 11 Jul 2023, Andy Shevchenko wrote:
>
> > On Tue, Jul 11, 2023 at 11:31 AM Fei Shao <[email protected]> wrote:
> > >
> > > Use the negated -EINVAL as the error code.
> >
> > Thank you, it seems Dan had been the first one.
> >
> > Message ID <[email protected]>
>
> I don't know much about how other people operate, but I have no way to
> trivially navigate to this. Would you be kind enough to use URLs
> please?
Use this pattern:
https://lore.kernel.org/r/$MSG_ID
where $MSG_ID is [email protected]
in this case.
Hence, the URL:
https://lore.kernel.org/r/[email protected]
Easier way is simply run `b4 mbox $MSG_ID` and open the loaded mbox
with your preferred MUA.
--
With Best Regards,
Andy Shevchenko
On Wed, 12 Jul 2023, Andy Shevchenko wrote:
> On Wed, Jul 12, 2023 at 3:00 PM Lee Jones <[email protected]> wrote:
> > On Tue, 11 Jul 2023, Andy Shevchenko wrote:
> >
> > > On Tue, Jul 11, 2023 at 11:31 AM Fei Shao <[email protected]> wrote:
> > > >
> > > > Use the negated -EINVAL as the error code.
> > >
> > > Thank you, it seems Dan had been the first one.
> > >
> > > Message ID <[email protected]>
> >
> > I don't know much about how other people operate, but I have no way to
> > trivially navigate to this. Would you be kind enough to use URLs
> > please?
>
> Use this pattern:
> https://lore.kernel.org/r/$MSG_ID
> where $MSG_ID is [email protected]
> in this case.
>
> Hence, the URL:
> https://lore.kernel.org/r/[email protected]
>
> Easier way is simply run `b4 mbox $MSG_ID` and open the loaded mbox
> with your preferred MUA.
Right, I'm aware that I can manually manipulate the lore URL in this way.
However I, like many, do not have a way to do this easily from my mailer.
This is why directly navigatable / clickable URLs were invented. :)
Please could you use full / clickable URLs to messages?
--
Lee Jones [李琼斯]