2023-07-11 11:16:40

by Nitin Rawat

Subject: [PATCH V1] scsi: ufs: ufs-qcom: Update UFS devfreq Parameters

To support the periodic polling mode without stop
caused by CPU idle state, enable delayed timer
as default instead of deferrable timer for
qualcomm platforms.
And change UFS devfreq downdifferential threshold to 65
for less aggresive downscaling.

Signed-off-by: Nitin Rawat <[email protected]>
Signed-off-by: Asutosh Das <[email protected]>
---
drivers/ufs/host/ufs-qcom.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c
index 82d02e7f3b4f..a15815c951ca 100644
--- a/drivers/ufs/host/ufs-qcom.c
+++ b/drivers/ufs/host/ufs-qcom.c
@@ -1388,8 +1388,9 @@ static void ufs_qcom_config_scaling_param(struct ufs_hba *hba,
struct devfreq_simple_ondemand_data *d)
{
p->polling_ms = 60;
+ p->timer = DEVFREQ_TIMER_DELAYED;
d->upthreshold = 70;
- d->downdifferential = 5;
+ d->downdifferential = 65;
}
#else
static void ufs_qcom_config_scaling_param(struct ufs_hba *hba,
--
2.17.1

2023-07-15 14:17:29

by Konrad Dybcio

Subject: Re: [PATCH V1] scsi: ufs: ufs-qcom: Update UFS devfreq Parameters

On 11.07.2023 12:40, Nitin Rawat wrote:
> To support the periodic polling mode without stop
> caused by CPU idle state, enable delayed timer
> as default instead of deferrable timer for
> qualcomm platforms.
> And change UFS devfreq downdifferential threshold to 65
> for less aggresive downscaling.
Please wrap your commit messages at around 70 characters, 50
makes it very hard to read.

Konrad
>
> Signed-off-by: Nitin Rawat <[email protected]>
> Signed-off-by: Asutosh Das <[email protected]>
> ---
> drivers/ufs/host/ufs-qcom.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c
> index 82d02e7f3b4f..a15815c951ca 100644
> --- a/drivers/ufs/host/ufs-qcom.c
> +++ b/drivers/ufs/host/ufs-qcom.c
> @@ -1388,8 +1388,9 @@ static void ufs_qcom_config_scaling_param(struct ufs_hba *hba,
> struct devfreq_simple_ondemand_data *d)
> {
> p->polling_ms = 60;
> + p->timer = DEVFREQ_TIMER_DELAYED;
> d->upthreshold = 70;
> - d->downdifferential = 5;
> + d->downdifferential = 65;
> }
> #else
> static void ufs_qcom_config_scaling_param(struct ufs_hba *hba,
> --
> 2.17.1
>