2023-07-10 09:59:34

by Haifeng Xu

Subject: [PATCH] mm/mm_init.c: mark check_for_memory() as __init

The only caller of check_for_memory() is free_area_init(), which
is annotated with __init, so it should be safe to also mark the
former as __init.

Signed-off-by: Haifeng Xu <[email protected]>
---
mm/mm_init.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/mm_init.c b/mm/mm_init.c
index a1963c3322af..a313d1828a6c 100644
--- a/mm/mm_init.c
+++ b/mm/mm_init.c
@@ -1737,7 +1737,7 @@ static void __init free_area_init_node(int nid)
}

/* Any regular or high memory on that node ? */
-static void check_for_memory(pg_data_t *pgdat)
+static void __init check_for_memory(pg_data_t *pgdat)
{
enum zone_type zone_type;

--
2.25.1

2023-07-11 18:30:44

by Mike Rapoport

Subject: Re: [PATCH] mm/mm_init.c: mark check_for_memory() as __init

On Mon, Jul 10, 2023 at 09:37:50AM +0000, Haifeng Xu wrote:
> The only caller of check_for_memory() is free_area_init(), which
> is annotated with __init, so it should be safe to also mark the
> former as __init.
>
> Signed-off-by: Haifeng Xu <[email protected]>

Reviewed-by: Mike Rapoport (IBM) <[email protected]>

> ---
> mm/mm_init.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/mm_init.c b/mm/mm_init.c
> index a1963c3322af..a313d1828a6c 100644
> --- a/mm/mm_init.c
> +++ b/mm/mm_init.c
> @@ -1737,7 +1737,7 @@ static void __init free_area_init_node(int nid)
> }
>
> /* Any regular or high memory on that node ? */
> -static void check_for_memory(pg_data_t *pgdat)
> +static void __init check_for_memory(pg_data_t *pgdat)
> {
> enum zone_type zone_type;
>
> --
> 2.25.1
>

--
Sincerely yours,
Mike.

2023-07-13 11:41:07

by Anshuman Khandual

Subject: Re: [PATCH] mm/mm_init.c: mark check_for_memory() as __init

On 7/10/23 15:07, Haifeng Xu wrote:
> The only caller of check_for_memory() is free_area_init(), which
> is annotated with __init, so it should be safe to also mark the
> former as __init.
>
> Signed-off-by: Haifeng Xu <[email protected]>

Reviewed-by: Anshuman Khandual <[email protected]>

> ---
> mm/mm_init.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/mm_init.c b/mm/mm_init.c
> index a1963c3322af..a313d1828a6c 100644
> --- a/mm/mm_init.c
> +++ b/mm/mm_init.c
> @@ -1737,7 +1737,7 @@ static void __init free_area_init_node(int nid)
> }
>
> /* Any regular or high memory on that node ? */
> -static void check_for_memory(pg_data_t *pgdat)
> +static void __init check_for_memory(pg_data_t *pgdat)
> {
> enum zone_type zone_type;
>