2023-07-10 02:47:06

by Li zeming

Subject: [PATCH] kernel: kprobes: Remove unnecessary ‘0’ values

it is assigned first, so it does not need to initialize the assignment.

Signed-off-by: Li zeming <[email protected]>
---
kernel/kprobes.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/kernel/kprobes.c b/kernel/kprobes.c
index 00e177de91cc..83e6f76fca04 100644
--- a/kernel/kprobes.c
+++ b/kernel/kprobes.c
@@ -1072,7 +1072,7 @@ static int kprobe_ftrace_enabled;
static int __arm_kprobe_ftrace(struct kprobe *p, struct ftrace_ops *ops,
int *cnt)
{
- int ret = 0;
+ int ret;

lockdep_assert_held(&kprobe_mutex);

@@ -1110,7 +1110,7 @@ static int arm_kprobe_ftrace(struct kprobe *p)
static int __disarm_kprobe_ftrace(struct kprobe *p, struct ftrace_ops *ops,
int *cnt)
{
- int ret = 0;
+ int ret;

lockdep_assert_held(&kprobe_mutex);

@@ -2692,7 +2692,7 @@ void kprobe_free_init_mem(void)

static int __init init_kprobes(void)
{
- int i, err = 0;
+ int i, err;

/* FIXME allocate the probe table, currently defined statically */
/* initialize all list heads */
--
2.18.2

2023-07-10 10:25:07

by Masami Hiramatsu

Subject: Re: [PATCH] kernel: kprobes: Remove unnecessary ‘0’ values

On Wed, 12 Jul 2023 02:53:53 +0800
Li zeming <[email protected]> wrote:

> it is assigned first, so it does not need to initialize the assignment.
>

Looks good to me.

Acked-by: Masami Hiramatsu (Google) <[email protected]>

Thanks!

> Signed-off-by: Li zeming <[email protected]>
> ---
> kernel/kprobes.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/kernel/kprobes.c b/kernel/kprobes.c
> index 00e177de91cc..83e6f76fca04 100644
> --- a/kernel/kprobes.c
> +++ b/kernel/kprobes.c
> @@ -1072,7 +1072,7 @@ static int kprobe_ftrace_enabled;
> static int __arm_kprobe_ftrace(struct kprobe *p, struct ftrace_ops *ops,
> int *cnt)
> {
> - int ret = 0;
> + int ret;
>
> lockdep_assert_held(&kprobe_mutex);
>
> @@ -1110,7 +1110,7 @@ static int arm_kprobe_ftrace(struct kprobe *p)
> static int __disarm_kprobe_ftrace(struct kprobe *p, struct ftrace_ops *ops,
> int *cnt)
> {
> - int ret = 0;
> + int ret;
>
> lockdep_assert_held(&kprobe_mutex);
>
> @@ -2692,7 +2692,7 @@ void kprobe_free_init_mem(void)
>
> static int __init init_kprobes(void)
> {
> - int i, err = 0;
> + int i, err;
>
> /* FIXME allocate the probe table, currently defined statically */
> /* initialize all list heads */
> --
> 2.18.2
>


--
Masami Hiramatsu (Google) <[email protected]>