Add another mux option for i2s pins, this is used on Octavo OSD32MP1-RED board.
Signed-off-by: Sean Nyekjaer <[email protected]>
Reviewed-by: Olivier Moysan <[email protected]>
---
arch/arm/boot/dts/stm32mp15-pinctrl.dtsi | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
diff --git a/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi b/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi
index e86d989dd351..d79f89f37bc7 100644
--- a/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi
+++ b/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi
@@ -686,6 +686,25 @@ pins {
};
};
+ i2s2_pins_b: i2s2-1 {
+ pins {
+ pinmux = <STM32_PINMUX('C', 3, AF5)>, /* I2S2_SDO */
+ <STM32_PINMUX('B', 12, AF5)>, /* I2S2_WS */
+ <STM32_PINMUX('B', 13, AF5)>; /* I2S2_CK */
+ bias-disable;
+ drive-push-pull;
+ slew-rate = <1>;
+ };
+ };
+
+ i2s2_sleep_pins_b: i2s2-sleep-1 {
+ pins {
+ pinmux = <STM32_PINMUX('C', 3, ANALOG)>, /* I2S2_SDO */
+ <STM32_PINMUX('B', 12, ANALOG)>, /* I2S2_WS */
+ <STM32_PINMUX('B', 13, ANALOG)>; /* I2S2_CK */
+ };
+ };
+
ltdc_pins_a: ltdc-0 {
pins {
pinmux = <STM32_PINMUX('G', 7, AF14)>, /* LCD_CLK */
--
2.40.0
Add another mux option for can pins, this is used on Octavo OSD32MP1-RED board.
Signed-off-by: Sean Nyekjaer <[email protected]>
Reviewed-by: Olivier Moysan <[email protected]>
---
arch/arm/boot/dts/stm32mp15-pinctrl.dtsi | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi b/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi
index 422db6dd466c..537908a20efb 100644
--- a/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi
+++ b/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi
@@ -1144,6 +1144,26 @@ pins {
};
};
+ m_can1_pins_d: m-can1-3 {
+ pins1 {
+ pinmux = <STM32_PINMUX('D', 1, AF9)>; /* CAN1_TX */
+ slew-rate = <1>;
+ drive-push-pull;
+ bias-disable;
+ };
+ pins2 {
+ pinmux = <STM32_PINMUX('D', 0, AF9)>; /* CAN1_RX */
+ bias-disable;
+ };
+ };
+
+ m_can1_sleep_pins_d: m_can1-sleep-3 {
+ pins {
+ pinmux = <STM32_PINMUX('D', 1, ANALOG)>, /* CAN1_TX */
+ <STM32_PINMUX('D', 0, ANALOG)>; /* CAN1_RX */
+ };
+ };
+
m_can2_pins_a: m-can2-0 {
pins1 {
pinmux = <STM32_PINMUX('B', 13, AF9)>; /* CAN2_TX */
--
2.40.0
According to the OSD32MP1 Power System overview[1] there is no hard
requirement for the ldo6 to be always-on.
[1]: https://octavosystems.com/app_notes/osd32mp1-power-system-overview/#connections
Signed-off-by: Sean Nyekjaer <[email protected]>
---
arch/arm/boot/dts/stm32mp15xx-osd32.dtsi | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm/boot/dts/stm32mp15xx-osd32.dtsi b/arch/arm/boot/dts/stm32mp15xx-osd32.dtsi
index 902ca6c23533..aeb71c41a734 100644
--- a/arch/arm/boot/dts/stm32mp15xx-osd32.dtsi
+++ b/arch/arm/boot/dts/stm32mp15xx-osd32.dtsi
@@ -152,9 +152,7 @@ v1v2_hdmi: ldo6 {
regulator-name = "v1v2_hdmi";
regulator-min-microvolt = <1200000>;
regulator-max-microvolt = <1200000>;
- regulator-always-on;
interrupts = <IT_CURLIM_LDO6 0>;
-
};
vref_ddr: vref_ddr {
--
2.40.0
Add binding support for the Octavo OSD32MP1-RED development board.
General features:
- STM32MP157C
- 512MB DDR3
- CAN-FD
- HDMI
- USB-C OTG
- UART
Signed-off-by: Sean Nyekjaer <[email protected]>
Acked-by: Conor Dooley <[email protected]>
---
Documentation/devicetree/bindings/arm/stm32/stm32.yaml | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
index 13e34241145b..55e45db1af26 100644
--- a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
+++ b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
@@ -143,7 +143,8 @@ properties:
- description: Octavo OSD32MP15x System-in-Package based boards
items:
- enum:
- - lxa,stm32mp157c-mc1 # Linux Automation MC-1
+ - lxa,stm32mp157c-mc1 # Linux Automation MC-1
+ - oct,stm32mp157c-osd32-red # Octavo OSD32MP1 RED board
- const: oct,stm32mp15xx-osd32
- enum:
- st,stm32mp157
--
2.40.0
Hello Sean,
On 12.07.23 08:29, Sean Nyekjaer wrote:
> Add binding support for the Octavo OSD32MP1-RED development board.
>
> General features:
> - STM32MP157C
> - 512MB DDR3
> - CAN-FD
> - HDMI
> - USB-C OTG
> - UART
>
> Signed-off-by: Sean Nyekjaer <[email protected]>
> Acked-by: Conor Dooley <[email protected]>
Just a heads up: The LXA TAC, another OSD32MP1 board has been merged into
stm32-next yesterday, so applying your series onto that tree may result
in conflicts. You may want to rebase for v4.
Cheers,
Ahmad
> ---
> Documentation/devicetree/bindings/arm/stm32/stm32.yaml | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
> index 13e34241145b..55e45db1af26 100644
> --- a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
> +++ b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
> @@ -143,7 +143,8 @@ properties:
> - description: Octavo OSD32MP15x System-in-Package based boards
> items:
> - enum:
> - - lxa,stm32mp157c-mc1 # Linux Automation MC-1
> + - lxa,stm32mp157c-mc1 # Linux Automation MC-1
> + - oct,stm32mp157c-osd32-red # Octavo OSD32MP1 RED board
> - const: oct,stm32mp15xx-osd32
> - enum:
> - st,stm32mp157
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
On 12.07.23 11:11, Sean Nyekjaer wrote:
>> On 12 Jul 2023, at 10.38, Ahmad Fatoum <[email protected]> wrote:
>> On 12.07.23 08:29, Sean Nyekjaer wrote:
>>> Add binding support for the Octavo OSD32MP1-RED development board.
>>>
>>> General features:
>>> - STM32MP157C
>>> - 512MB DDR3
>>> - CAN-FD
>>> - HDMI
>>> - USB-C OTG
>>> - UART
>>>
>>> Signed-off-by: Sean Nyekjaer <[email protected]>
>>> Acked-by: Conor Dooley <[email protected]>
>>
>> Just a heads up: The LXA TAC, another OSD32MP1 board has been merged into
>> stm32-next yesterday, so applying your series onto that tree may result
>> in conflicts. You may want to rebase for v4.
>>
>> Cheers,
>> Ahmad
>
> Thanks, will do :)
>
> Can I get you to look at 4/8, 5/8 and 6/8 in this series? Will they break anything for LXA TAC?
Leonard, does the LXA TAC have an implicit dependency on any of the rails that Sean is
now turning off by default?
Cheers,
Ahmad
>
> /Sean
>
>>
>>
>>> ---
>>> Documentation/devicetree/bindings/arm/stm32/stm32.yaml | 3 ++-
>>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
>>> index 13e34241145b..55e45db1af26 100644
>>> --- a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
>>> +++ b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
>>> @@ -143,7 +143,8 @@ properties:
>>> - description: Octavo OSD32MP15x System-in-Package based boards
>>> items:
>>> - enum:
>>> - - lxa,stm32mp157c-mc1 # Linux Automation MC-1
>>> + - lxa,stm32mp157c-mc1 # Linux Automation MC-1
>>> + - oct,stm32mp157c-osd32-red # Octavo OSD32MP1 RED board
>>> - const: oct,stm32mp15xx-osd32
>>> - enum:
>>> - st,stm32mp157
>>
>> --
>> Pengutronix e.K. | |
>> Steuerwalder Str. 21 | http://www.pengutronix.de/ |
>> 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
>> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
>
>
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
> On 12 Jul 2023, at 10.38, Ahmad Fatoum <[email protected]> wrote:
>
> Hello Sean,
>
> On 12.07.23 08:29, Sean Nyekjaer wrote:
>> Add binding support for the Octavo OSD32MP1-RED development board.
>>
>> General features:
>> - STM32MP157C
>> - 512MB DDR3
>> - CAN-FD
>> - HDMI
>> - USB-C OTG
>> - UART
>>
>> Signed-off-by: Sean Nyekjaer <[email protected]>
>> Acked-by: Conor Dooley <[email protected]>
>
> Just a heads up: The LXA TAC, another OSD32MP1 board has been merged into
> stm32-next yesterday, so applying your series onto that tree may result
> in conflicts. You may want to rebase for v4.
>
> Cheers,
> Ahmad
Thanks, will do :)
Can I get you to look at 4/8, 5/8 and 6/8 in this series? Will they break anything for LXA TAC?
/Sean
>
>
>> ---
>> Documentation/devicetree/bindings/arm/stm32/stm32.yaml | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
>> index 13e34241145b..55e45db1af26 100644
>> --- a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
>> +++ b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
>> @@ -143,7 +143,8 @@ properties:
>> - description: Octavo OSD32MP15x System-in-Package based boards
>> items:
>> - enum:
>> - - lxa,stm32mp157c-mc1 # Linux Automation MC-1
>> + - lxa,stm32mp157c-mc1 # Linux Automation MC-1
>> + - oct,stm32mp157c-osd32-red # Octavo OSD32MP1 RED board
>> - const: oct,stm32mp15xx-osd32
>> - enum:
>> - st,stm32mp157
>
> --
> Pengutronix e.K. | |
> Steuerwalder Str. 21 | http://www.pengutronix.de/ |
> 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
On 12.07.23 11:18, Ahmad Fatoum wrote:
> On 12.07.23 11:11, Sean Nyekjaer wrote:
>>> On 12 Jul 2023, at 10.38, Ahmad Fatoum <[email protected]> wrote:
>>> On 12.07.23 08:29, Sean Nyekjaer wrote:
>>>> Add binding support for the Octavo OSD32MP1-RED development board.
>>>>
>>>> General features:
>>>> - STM32MP157C
>>>> - 512MB DDR3
>>>> - CAN-FD
>>>> - HDMI
>>>> - USB-C OTG
>>>> - UART
>>>>
>>>> Signed-off-by: Sean Nyekjaer <[email protected]>
>>>> Acked-by: Conor Dooley <[email protected]>
>>>
>>> Just a heads up: The LXA TAC, another OSD32MP1 board has been merged into
>>> stm32-next yesterday, so applying your series onto that tree may result
>>> in conflicts. You may want to rebase for v4.
>>>
>>> Cheers,
>>> Ahmad
>>
>> Thanks, will do :)
>>
>> Can I get you to look at 4/8, 5/8 and 6/8 in this series? Will they break anything for LXA TAC?
>
> Leonard, does the LXA TAC have an implicit dependency on any of the rails that Sean is
> now turning off by default?
No, removing the regulator-always-on for these three regulators on the LXA TAC should be fine.
We do not use v1v2_hdmi and v1v8_audio at all and already have
"/delete-property/regulator-always-on" in our stm32mp15xc-lxa-tac.dtsi for v3v3_hdmi,
which becomes obsolete with this patch.
I would appreciate it if you added patch to remove it from stm32mp15xc-lxa-tac.dtsi if you
send a v4.
You can add my Acked-by: Leonard Göhrs <[email protected]> to these three patches,
if you like.
Greetings
Leonard
> Cheers,
> Ahmad
>
>>
>> /Sean
>>
>>>
>>>
>>>> ---
>>>> Documentation/devicetree/bindings/arm/stm32/stm32.yaml | 3 ++-
>>>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
>>>> index 13e34241145b..55e45db1af26 100644
>>>> --- a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
>>>> +++ b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
>>>> @@ -143,7 +143,8 @@ properties:
>>>> - description: Octavo OSD32MP15x System-in-Package based boards
>>>> items:
>>>> - enum:
>>>> - - lxa,stm32mp157c-mc1 # Linux Automation MC-1
>>>> + - lxa,stm32mp157c-mc1 # Linux Automation MC-1
>>>> + - oct,stm32mp157c-osd32-red # Octavo OSD32MP1 RED board
>>>> - const: oct,stm32mp15xx-osd32
>>>> - enum:
>>>> - st,stm32mp157
>>>
>>> --
>>> Pengutronix e.K. | |
>>> Steuerwalder Str. 21 | http://www.pengutronix.de/ |
>>> 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
>>> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
>>
>>
>>
>>
>