2023-07-12 12:16:32

by Minjie Du

Subject: [PATCH v2] i2c: busses: fix parameter check in i2c_gpio_fault_injector_init()

Make IS_ERR() judge the debugfs_create_dir() function return.

Signed-off-by: Minjie Du <[email protected]>

v1-v2:
Fix judge typo.
---
drivers/i2c/busses/i2c-gpio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/i2c/busses/i2c-gpio.c b/drivers/i2c/busses/i2c-gpio.c
index e5a5b9e8b..545927b96 100644
--- a/drivers/i2c/busses/i2c-gpio.c
+++ b/drivers/i2c/busses/i2c-gpio.c
@@ -265,7 +265,7 @@ static void i2c_gpio_fault_injector_init(struct platform_device *pdev)
*/
if (!i2c_gpio_debug_dir) {
i2c_gpio_debug_dir = debugfs_create_dir("i2c-fault-injector", NULL);
- if (!i2c_gpio_debug_dir)
+ if (IS_ERR(i2c_gpio_debug_dir))
return;
}

--
2.39.0

2023-07-12 15:17:03

by Andi Shyti

Subject: Re: [PATCH v2] i2c: busses: fix parameter check in i2c_gpio_fault_injector_init()

Hi Minje,

On Wed, Jul 12, 2023 at 07:22:22PM +0800, Minjie Du wrote:
> Make IS_ERR() judge the debugfs_create_dir() function return.
>
> Signed-off-by: Minjie Du <[email protected]>
>
> v1-v2:
> Fix judge typo.

Please next time add the changelog after the "---" section.

You will also need:

Fixes: 14911c6f48ec ("i2c: gpio: add fault injector")
Cc: Wolfram Sang <[email protected]>
Cc: <[email protected]> # v4.16+

Said that:

Reviewed-by: Andi Shyti <[email protected]>

Andi

> ---
> drivers/i2c/busses/i2c-gpio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-gpio.c b/drivers/i2c/busses/i2c-gpio.c
> index e5a5b9e8b..545927b96 100644
> --- a/drivers/i2c/busses/i2c-gpio.c
> +++ b/drivers/i2c/busses/i2c-gpio.c
> @@ -265,7 +265,7 @@ static void i2c_gpio_fault_injector_init(struct platform_device *pdev)
> */
> if (!i2c_gpio_debug_dir) {
> i2c_gpio_debug_dir = debugfs_create_dir("i2c-fault-injector", NULL);
> - if (!i2c_gpio_debug_dir)
> + if (IS_ERR(i2c_gpio_debug_dir))
> return;
> }
>
> --
> 2.39.0
>