2023-07-12 13:24:52

by Sean Nyekjaer

[permalink] [raw]
Subject: [PATCH v4 8/9] dt-bindings: arm: stm32: add extra SiP compatible for oct,stm32mp157c-osd32-red

Add binding support for the Octavo OSD32MP1-RED development board.

General features:
- STM32MP157C
- 512MB DDR3
- CAN-FD
- HDMI
- USB-C OTG
- UART

Signed-off-by: Sean Nyekjaer <[email protected]>
---
Documentation/devicetree/bindings/arm/stm32/stm32.yaml | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
index 4bf28e717a56..232abdcef0fd 100644
--- a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
+++ b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
@@ -143,9 +143,10 @@ properties:
- description: Octavo OSD32MP15x System-in-Package based boards
items:
- enum:
- - lxa,stm32mp157c-mc1 # Linux Automation MC-1
- - lxa,stm32mp157c-tac-gen1 # Linux Automation TAC (Generation 1)
- - lxa,stm32mp157c-tac-gen2 # Linux Automation TAC (Generation 2)
+ - lxa,stm32mp157c-mc1 # Linux Automation MC-1
+ - lxa,stm32mp157c-tac-gen1 # Linux Automation TAC (Generation 1)
+ - lxa,stm32mp157c-tac-gen2 # Linux Automation TAC (Generation 2)
+ - oct,stm32mp157c-osd32-red # Octavo OSD32MP1 RED board
- const: oct,stm32mp15xx-osd32
- enum:
- st,stm32mp157
--
2.40.0



2023-07-12 19:11:20

by Conor Dooley

[permalink] [raw]
Subject: Re: [PATCH v4 8/9] dt-bindings: arm: stm32: add extra SiP compatible for oct,stm32mp157c-osd32-red

On Wed, Jul 12, 2023 at 02:42:46PM +0200, Sean Nyekjaer wrote:
> Add binding support for the Octavo OSD32MP1-RED development board.
>
> General features:
> - STM32MP157C
> - 512MB DDR3
> - CAN-FD
> - HDMI
> - USB-C OTG
> - UART
>
> Signed-off-by: Sean Nyekjaer <[email protected]>

Acked-by: Conor Dooley <[email protected]>

Cheers,
Conor.

Attachments:
(No filename) (373.00 B)
 signature.asc (235.00 B)
 Download all attachments

2023-07-12 19:49:10

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v4 8/9] dt-bindings: arm: stm32: add extra SiP compatible for oct,stm32mp157c-osd32-red

On 12/07/2023 14:42, Sean Nyekjaer wrote:
> Add binding support for the Octavo OSD32MP1-RED development board.
>
> General features:
> - STM32MP157C
> - 512MB DDR3
> - CAN-FD
> - HDMI
> - USB-C OTG
> - UART
>
> Signed-off-by: Sean Nyekjaer <[email protected]>
> ---
> Documentation/devicetree/bindings/arm/stm32/stm32.yaml | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
> index 4bf28e717a56..232abdcef0fd 100644
> --- a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
> +++ b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
> @@ -143,9 +143,10 @@ properties:
> - description: Octavo OSD32MP15x System-in-Package based boards
> items:
> - enum:
> - - lxa,stm32mp157c-mc1 # Linux Automation MC-1
> - - lxa,stm32mp157c-tac-gen1 # Linux Automation TAC (Generation 1)
> - - lxa,stm32mp157c-tac-gen2 # Linux Automation TAC (Generation 2)
> + - lxa,stm32mp157c-mc1 # Linux Automation MC-1
> + - lxa,stm32mp157c-tac-gen1 # Linux Automation TAC (Generation 1)
> + - lxa,stm32mp157c-tac-gen2 # Linux Automation TAC (Generation 2)
> + - oct,stm32mp157c-osd32-red # Octavo OSD32MP1 RED board

I would prefer the change without touching previous lines for
re-indenting the comment. However it's ok if your arch maintainers is happy:

Acked-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof