2023-07-12 13:41:00

by Minjie Du

[permalink] [raw]
Subject: [PATCH v1] lib: fix two parameters check in ei_debugfs_init()

Make IS_ERR() judge the debugfs_create_dir() function return
in ei_debugfs_init().

Signed-off-by: Minjie Du <[email protected]>
---
lib/error-inject.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/error-inject.c b/lib/error-inject.c
index 32c147705..9dd2c5ca3 100644
--- a/lib/error-inject.c
+++ b/lib/error-inject.c
@@ -217,11 +217,11 @@ static int __init ei_debugfs_init(void)
struct dentry *dir, *file;

dir = debugfs_create_dir("error_injection", NULL);
- if (!dir)
+ if (IS_ERR(dir))
return -ENOMEM;

file = debugfs_create_file("list", 0444, dir, NULL, &ei_fops);
- if (!file) {
+ if (IS_ERR(file)) {
debugfs_remove(dir);
return -ENOMEM;
}
--
2.39.0