2023-07-12 16:26:32

by Lukasz Majewski

[permalink] [raw]
Subject: [PATCH] ARM: dts: at91: ksz9477_evb: Add missing timer nodes

Without this change the KSZ9477-EVB board hangs just after passing
execution flow from u-boot to Linux kernel.

This code has been copied from at91-sama5d3_xplained.dts.

Test setup: Linux 6.5-rc1
Config: arch/arm/configs/sama5_defconfig
Toolchain: gcc-linaro-7.3.1-2018.05-x86_64_arm-linux-gnueabi

Signed-off-by: Lukasz Majewski <[email protected]>
---
.../boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts | 12 ++++++++++++
1 file changed, 12 insertions(+)

diff --git a/arch/arm/boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts b/arch/arm/boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts
index 14af1fd6d247..99cd6d15998b 100644
--- a/arch/arm/boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts
+++ b/arch/arm/boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts
@@ -162,6 +162,18 @@
};
};

+&tcb0 {
+ timer0: timer@0 {
+ compatible = "atmel,tcb-timer";
+ reg = <0>;
+ };
+
+ timer1: timer@1 {
+ compatible = "atmel,tcb-timer";
+ reg = <1>;
+ };
+};
+
&usb0 {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_usba_vbus>;
--
2.20.1



2023-07-26 09:30:12

by Lukasz Majewski

[permalink] [raw]
Subject: Re: [PATCH] ARM: dts: at91: ksz9477_evb: Add missing timer nodes

Dear Community,

> Without this change the KSZ9477-EVB board hangs just after passing
> execution flow from u-boot to Linux kernel.
>
> This code has been copied from at91-sama5d3_xplained.dts.
>
> Test setup: Linux 6.5-rc1
> Config: arch/arm/configs/sama5_defconfig
> Toolchain: gcc-linaro-7.3.1-2018.05-x86_64_arm-linux-gnueabi
>
> Signed-off-by: Lukasz Majewski <[email protected]>
> ---
> .../boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts | 12
> ++++++++++++ 1 file changed, 12 insertions(+)
>
> diff --git a/arch/arm/boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts
> b/arch/arm/boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts index
> 14af1fd6d247..99cd6d15998b 100644 ---
> a/arch/arm/boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts +++
> b/arch/arm/boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts @@ -162,6
> +162,18 @@ };
> };
>
> +&tcb0 {
> + timer0: timer@0 {
> + compatible = "atmel,tcb-timer";
> + reg = <0>;
> + };
> +
> + timer1: timer@1 {
> + compatible = "atmel,tcb-timer";
> + reg = <1>;
> + };
> +};
> +
> &usb0 {
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_usba_vbus>;

Gentle ping on this fix ...


Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: [email protected]


Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2023-07-26 19:34:43

by Conor Dooley

[permalink] [raw]
Subject: Re: [PATCH] ARM: dts: at91: ksz9477_evb: Add missing timer nodes

On Wed, Jul 26, 2023 at 10:19:02AM +0200, Lukasz Majewski wrote:
> Dear Community,
>
> > Without this change the KSZ9477-EVB board hangs just after passing
> > execution flow from u-boot to Linux kernel.
> >
> > This code has been copied from at91-sama5d3_xplained.dts.
> >
> > Test setup: Linux 6.5-rc1
> > Config: arch/arm/configs/sama5_defconfig
> > Toolchain: gcc-linaro-7.3.1-2018.05-x86_64_arm-linux-gnueabi
> >
> > Signed-off-by: Lukasz Majewski <[email protected]>
> > ---
> > .../boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts | 12
> > ++++++++++++ 1 file changed, 12 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts
> > b/arch/arm/boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts index
> > 14af1fd6d247..99cd6d15998b 100644 ---
> > a/arch/arm/boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts +++
> > b/arch/arm/boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts @@ -162,6
> > +162,18 @@ };
> > };
> >
> > +&tcb0 {
> > + timer0: timer@0 {
> > + compatible = "atmel,tcb-timer";
> > + reg = <0>;
> > + };
> > +
> > + timer1: timer@1 {
> > + compatible = "atmel,tcb-timer";
> > + reg = <1>;
> > + };
> > +};
> > +
> > &usb0 {
> > pinctrl-names = "default";
> > pinctrl-0 = <&pinctrl_usba_vbus>;
>
> Gentle ping on this fix ...

Claudiu has left Microchip, so things might've got a bit lost on the
way. I've added his new address, Claudiu, will you take a look/pick this
up please? I can also do it if that is easier for you.

Thanks,
Conor.


Attachments:
(No filename) (1.52 kB)
signature.asc (235.00 B)
Download all attachments

2023-07-27 06:46:33

by Claudiu

[permalink] [raw]
Subject: Re: [PATCH] ARM: dts: at91: ksz9477_evb: Add missing timer nodes



On 26.07.2023 21:33, Conor Dooley wrote:
> On Wed, Jul 26, 2023 at 10:19:02AM +0200, Lukasz Majewski wrote:
>> Dear Community,
>>
>>> Without this change the KSZ9477-EVB board hangs just after passing
>>> execution flow from u-boot to Linux kernel.
>>>
>>> This code has been copied from at91-sama5d3_xplained.dts.
>>>
>>> Test setup: Linux 6.5-rc1
>>> Config: arch/arm/configs/sama5_defconfig
>>> Toolchain: gcc-linaro-7.3.1-2018.05-x86_64_arm-linux-gnueabi
>>>
>>> Signed-off-by: Lukasz Majewski <[email protected]>
>>> ---
>>> .../boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts | 12
>>> ++++++++++++ 1 file changed, 12 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts
>>> b/arch/arm/boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts index
>>> 14af1fd6d247..99cd6d15998b 100644 ---
>>> a/arch/arm/boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts +++
>>> b/arch/arm/boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts @@ -162,6
>>> +162,18 @@ };
>>> };
>>>
>>> +&tcb0 {
>>> + timer0: timer@0 {
>>> + compatible = "atmel,tcb-timer";
>>> + reg = <0>;
>>> + };
>>> +
>>> + timer1: timer@1 {
>>> + compatible = "atmel,tcb-timer";
>>> + reg = <1>;
>>> + };
>>> +};
>>> +
>>> &usb0 {
>>> pinctrl-names = "default";
>>> pinctrl-0 = <&pinctrl_usba_vbus>;
>>
>> Gentle ping on this fix ...
>
> Claudiu has left Microchip, so things might've got a bit lost on the
> way. I've added his new address, Claudiu, will you take a look/pick this
> up please? I can also do it if that is easier for you.

It's on my list.

Thanks,
Claudiu

>
> Thanks,
> Conor.
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> [email protected]
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

2023-08-02 05:39:46

by Claudiu

[permalink] [raw]
Subject: Re: [PATCH] ARM: dts: at91: ksz9477_evb: Add missing timer nodes



On 26.07.2023 11:19, Lukasz Majewski wrote:
> Dear Community,
>
>> Without this change the KSZ9477-EVB board hangs just after passing
>> execution flow from u-boot to Linux kernel.
>>
>> This code has been copied from at91-sama5d3_xplained.dts.
>>
>> Test setup: Linux 6.5-rc1
>> Config: arch/arm/configs/sama5_defconfig
>> Toolchain: gcc-linaro-7.3.1-2018.05-x86_64_arm-linux-gnueabi
>>
>> Signed-off-by: Lukasz Majewski <[email protected]>

Applied to at91-dt, thanks!