2023-07-07 03:01:05

by Zhang, Rui

Subject: [PATCH] sched/fair: Remove repeated words in a comment

Remove repeated words in a comment.

Signed-off-by: Zhang Rui <[email protected]>
---
kernel/sched/fair.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index a80a73909dc2..2d6f47eecb66 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -10700,8 +10700,8 @@ asym_active_balance(struct lb_env *env)
/*
* ASYM_PACKING needs to force migrate tasks from busy but lower
* priority CPUs in order to pack all tasks in the highest priority
- * CPUs. When done between cores, do it only if the whole core if the
- * whole core is idle.
+ * CPUs. When done between cores, do it only if the whole core is
+ * idle.
*
* If @env::src_cpu is an SMT core with busy siblings, let
* the lower priority @env::dst_cpu help it. Do not follow
--
2.34.1

2023-07-12 19:25:53

by Ricardo Neri

Subject: Re: [PATCH] sched/fair: Remove repeated words in a comment

On Fri, Jul 07, 2023 at 10:44:20AM +0800, Zhang Rui wrote:
> Remove repeated words in a comment.
>
> Signed-off-by: Zhang Rui <[email protected]>
> ---
> kernel/sched/fair.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index a80a73909dc2..2d6f47eecb66 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -10700,8 +10700,8 @@ asym_active_balance(struct lb_env *env)
> /*
> * ASYM_PACKING needs to force migrate tasks from busy but lower
> * priority CPUs in order to pack all tasks in the highest priority
> - * CPUs. When done between cores, do it only if the whole core if the
> - * whole core is idle.
> + * CPUs. When done between cores, do it only if the whole core is
> + * idle.

Ah! I missed this.

FWIW, Reviewed-by: Ricardo Neri <[email protected]>