2023-07-12 22:41:31

by Linus Walleij

[permalink] [raw]
Subject: [PATCH v4 0/2] (no cover subject)

This type of firmware partition appear in some devices in
NAND flash, so we need to be able to tag the partitions
with the appropriate type.

The origin of the "SEAttle iMAge" is unknown.

Signed-off-by: Linus Walleij <[email protected]>
---
Changes in v4:
- Drop the false tagging of #address-cells etc
- Link to v3: https://lore.kernel.org/r/[email protected]

Changes in v3:
- Drop reference from partitions.yaml again
- Drop select: false
- Use unevaluatedProperties
- Link to v2: https://lore.kernel.org/r/[email protected]

Changes in v2:
- Make the binding clearly childless
- Link to v1: https://lore.kernel.org/r/[email protected]

---
Linus Walleij (2):
dt-bindings: mtd: Add SEAMA partition bindings
ARM: dts: bcm5301x: Add SEAMA compatibles

.../devicetree/bindings/mtd/partitions/seama.yaml | 44 ++++++++++++++++++++++
arch/arm/boot/dts/bcm47094-dlink-dir-885l.dts | 1 +
arch/arm/boot/dts/bcm47094-dlink-dir-890l.dts | 1 +
3 files changed, 46 insertions(+)
---
base-commit: 035cd1416934ef7ae5374272d3c9e378c3d7049c
change-id: 20230506-seama-partitions-b620117b9985

Best regards,
--
Linus Walleij <[email protected]>



2023-07-12 22:42:02

by Linus Walleij

[permalink] [raw]
Subject: [PATCH v4 1/2] dt-bindings: mtd: Add SEAMA partition bindings

This types of NAND partitions appear in OpenWrt and
U-Boot.

Signed-off-by: Linus Walleij <[email protected]>
---
ChangeLog v3->v4:
- Drop false flagged cells etc.
ChangeLog v2->v3:
- Drop reference from partitions.yaml again
- Drop select: false
- Use unevaluatedProperties
ChangeLog v1->v2:
- Fix up the binding to be childless
---
.../devicetree/bindings/mtd/partitions/seama.yaml | 44 ++++++++++++++++++++++
1 file changed, 44 insertions(+)

diff --git a/Documentation/devicetree/bindings/mtd/partitions/seama.yaml b/Documentation/devicetree/bindings/mtd/partitions/seama.yaml
new file mode 100644
index 000000000000..4c1cbf43e81a
--- /dev/null
+++ b/Documentation/devicetree/bindings/mtd/partitions/seama.yaml
@@ -0,0 +1,44 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/mtd/partitions/seama.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Seattle Image Partitions
+
+description: The SEAttle iMAge (SEAMA) partition is a type of partition
+ used for NAND flash devices. This type of flash image is found in some
+ D-Link routers such as DIR-645, DIR-842, DIR-859, DIR-860L, DIR-885L,
+ DIR890L and DCH-M225, as well as in WD and NEC routers on the ath79
+ (MIPS), Broadcom BCM53xx, and RAMIPS platforms. This partition type
+ does not have children defined in the device tree, they need to be
+ detected by software.
+
+allOf:
+ - $ref: partition.yaml#
+
+maintainers:
+ - Linus Walleij <[email protected]>
+
+properties:
+ compatible:
+ const: seama
+
+required:
+ - compatible
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ partitions {
+ compatible = "fixed-partitions";
+ #address-cells = <1>;
+ #size-cells = <1>;
+
+ partition@0 {
+ compatible = "seama";
+ reg = <0x0 0x800000>;
+ label = "firmware";
+ };
+ };

--
2.34.1


2023-07-12 23:03:11

by Linus Walleij

[permalink] [raw]
Subject: [PATCH v4 2/2] ARM: dts: bcm5301x: Add SEAMA compatibles

This adds SEAMA compatibles to the firmware partition of these
two D-Link devices.

Signed-off-by: Linus Walleij <[email protected]>
---
arch/arm/boot/dts/bcm47094-dlink-dir-885l.dts | 1 +
arch/arm/boot/dts/bcm47094-dlink-dir-890l.dts | 1 +
2 files changed, 2 insertions(+)

diff --git a/arch/arm/boot/dts/bcm47094-dlink-dir-885l.dts b/arch/arm/boot/dts/bcm47094-dlink-dir-885l.dts
index 555fbe41dd8f..cf3000b07eea 100644
--- a/arch/arm/boot/dts/bcm47094-dlink-dir-885l.dts
+++ b/arch/arm/boot/dts/bcm47094-dlink-dir-885l.dts
@@ -33,6 +33,7 @@ partitions {
#size-cells = <1>;

partition@0 {
+ compatible = "seama";
label = "firmware";
reg = <0x00000000 0x08000000>;
};
diff --git a/arch/arm/boot/dts/bcm47094-dlink-dir-890l.dts b/arch/arm/boot/dts/bcm47094-dlink-dir-890l.dts
index d945a20b06e0..3551f855ff20 100644
--- a/arch/arm/boot/dts/bcm47094-dlink-dir-890l.dts
+++ b/arch/arm/boot/dts/bcm47094-dlink-dir-890l.dts
@@ -149,6 +149,7 @@ partitions {
* partitions: this device uses SEAMA.
*/
firmware@0 {
+ compatible = "seama";
label = "firmware";
reg = <0x00000000 0x08000000>;
};

--
2.34.1


2023-07-14 17:12:16

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH v4 1/2] dt-bindings: mtd: Add SEAMA partition bindings


On Thu, 13 Jul 2023 00:16:41 +0200, Linus Walleij wrote:
> This types of NAND partitions appear in OpenWrt and
> U-Boot.
>
> Signed-off-by: Linus Walleij <[email protected]>
> ---
> ChangeLog v3->v4:
> - Drop false flagged cells etc.
> ChangeLog v2->v3:
> - Drop reference from partitions.yaml again
> - Drop select: false
> - Use unevaluatedProperties
> ChangeLog v1->v2:
> - Fix up the binding to be childless
> ---
> .../devicetree/bindings/mtd/partitions/seama.yaml | 44 ++++++++++++++++++++++
> 1 file changed, 44 insertions(+)
>

Reviewed-by: Rob Herring <[email protected]>


2023-07-15 16:59:22

by Miquel Raynal

[permalink] [raw]
Subject: Re: [PATCH v4 1/2] dt-bindings: mtd: Add SEAMA partition bindings

On Wed, 2023-07-12 at 22:16:41 UTC, Linus Walleij wrote:
> This types of NAND partitions appear in OpenWrt and
> U-Boot.
>
> Signed-off-by: Linus Walleij <[email protected]>
> Reviewed-by: Rob Herring <[email protected]>

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks.

Miquel

2023-07-21 17:17:32

by Florian Fainelli

[permalink] [raw]
Subject: Re: [PATCH v4 2/2] ARM: dts: bcm5301x: Add SEAMA compatibles



On 7/12/2023 3:16 PM, Linus Walleij wrote:
> This adds SEAMA compatibles to the firmware partition of these
> two D-Link devices.
>
> Signed-off-by: Linus Walleij <[email protected]>

Applied by adjusting the patch after 6.5-rc1 moved the various DTS files
to vendor directories. Thanks Linus!
--
Florian


Attachments:
smime.p7s (4.12 kB)
S/MIME Cryptographic Signature