2023-07-13 07:31:35

by Minjie Du

Subject: [PATCH v4] iommu: remove redundant parameter check in tegra_smmu_debugfs_init()

debugfs_create_file() will return early if smmu->debugfs is an error
pointer, so an extra error check is not needed.

Signed-off-by: Minjie Du <[email protected]>
Acked-by: Thierry Reding <[email protected]>
---
drivers/iommu/tegra-smmu.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/iommu/tegra-smmu.c b/drivers/iommu/tegra-smmu.c
index 1cbf063cc..2137040b7 100644
--- a/drivers/iommu/tegra-smmu.c
+++ b/drivers/iommu/tegra-smmu.c
@@ -1056,8 +1056,6 @@ DEFINE_SHOW_ATTRIBUTE(tegra_smmu_clients);
static void tegra_smmu_debugfs_init(struct tegra_smmu *smmu)
{
smmu->debugfs = debugfs_create_dir("smmu", NULL);
- if (!smmu->debugfs)
- return;

debugfs_create_file("swgroups", S_IRUGO, smmu->debugfs, smmu,
&tegra_smmu_swgroups_fops);
--
2.39.0

2023-07-14 02:50:05

by Baolu Lu

Subject: Re: [PATCH v4] iommu: remove redundant parameter check in tegra_smmu_debugfs_init()

On 2023/7/13 15:28, Minjie Du wrote:
> debugfs_create_file() will return early if smmu->debugfs is an error
> pointer, so an extra error check is not needed.
>
> Signed-off-by: Minjie Du <[email protected]>
> Acked-by: Thierry Reding <[email protected]>
> ---
> drivers/iommu/tegra-smmu.c | 2 --
> 1 file changed, 2 deletions(-)

Next time when you send a new version of a patch, please don't forget to
add the change log after the tear line. This way, people can know how
the patch evolved into this way.

Best regards,
baolu

>
> diff --git a/drivers/iommu/tegra-smmu.c b/drivers/iommu/tegra-smmu.c
> index 1cbf063cc..2137040b7 100644
> --- a/drivers/iommu/tegra-smmu.c
> +++ b/drivers/iommu/tegra-smmu.c
> @@ -1056,8 +1056,6 @@ DEFINE_SHOW_ATTRIBUTE(tegra_smmu_clients);
> static void tegra_smmu_debugfs_init(struct tegra_smmu *smmu)
> {
> smmu->debugfs = debugfs_create_dir("smmu", NULL);
> - if (!smmu->debugfs)
> - return;
>
> debugfs_create_file("swgroups", S_IRUGO, smmu->debugfs, smmu,
> &tegra_smmu_swgroups_fops);

2023-07-14 03:30:34

by Baolu Lu

Subject: Re: [PATCH v4] iommu: remove redundant parameter check in tegra_smmu_debugfs_init()

On 2023/7/13 15:28, Minjie Du wrote:
> debugfs_create_file() will return early if smmu->debugfs is an error
> pointer, so an extra error check is not needed.
>
> Signed-off-by: Minjie Du<[email protected]>
> Acked-by: Thierry Reding<[email protected]>

Greg keeps reminding that no error branch for debugfs, so

Reviewed-by: Lu Baolu <[email protected]>

Best regards,
baolu