2023-07-13 08:03:47

by Miquel Raynal

[permalink] [raw]
Subject: Re: [PATCH v4 5/5] mtd: rawnand: brcmnand: Fix mtd oobsize

On Thu, 2023-07-06 at 18:29:09 UTC, William Zhang wrote:
> brcmnand controller can only access the flash spare area up to certain
> bytes based on the ECC level. It can be less than the actual flash spare
> area size. For example, for many NAND chip supporting ECC BCH-8, it has
> 226 bytes spare area. But controller can only uses 218 bytes. So brcmand
> driver overrides the mtd oobsize with the controller's accessible spare
> area size. When the nand base driver utilizes the nand_device object, it
> resets the oobsize back to the actual flash spare aprea size from
> nand_memory_organization structure and controller may not able to access
> all the oob area as mtd advises.
>
> This change fixes the issue by overriding the oobsize in the
> nand_memory_organization structure to the controller's accessible spare
> area size.
>
> Fixes: a7ab085d7c16 ("mtd: rawnand: Initialize the nand_device object")
> Signed-off-by: William Zhang <[email protected]>

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.

Miquel

2023-07-13 08:32:04

by Miquel Raynal

[permalink] [raw]
Subject: Re: [PATCH v4 3/5] mtd: rawnand: brcmnand: Fix crash during the panic_write

On Thu, 2023-07-06 at 18:29:07 UTC, William Zhang wrote:
> When executing a NAND command within the panic write path, wait for any
> pending command instead of calling BUG_ON to avoid crashing while
> already crashing.
>
> Fixes: 27c5b17cd1b1 ("mtd: nand: add NAND driver "library" for Broadcom STB NAND controller")
> Signed-off-by: William Zhang <[email protected]>
> Reviewed-by: Florian Fainelli <[email protected]>
> Reviewed-by: Kursad Oney <[email protected]>
> Reviewed-by: Kamal Dasu <[email protected]>
> Cc: [email protected]

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.

Miquel