2023-07-13 08:15:07

by Ivan Orlov

[permalink] [raw]
Subject: [PATCH v2 1/2] ALSA: pcmtest: Add 'open' PCM callback error injection

Extend 'pcmtest' virtual driver with 'open' callback error injection
functionality, as it already can inject errors into other PCM callbacks.
Add module parameter which enables EBUSY error injection in the 'open'
PCM callback.

Signed-off-by: Ivan Orlov <[email protected]>
---
V1 -> V2:
- Split changes in the patch into two different patches

sound/drivers/pcmtest.c | 7 +++++++
1 file changed, 7 insertions(+)

diff --git a/sound/drivers/pcmtest.c b/sound/drivers/pcmtest.c
index 291e7fe47893..e74c523e49eb 100644
--- a/sound/drivers/pcmtest.c
+++ b/sound/drivers/pcmtest.c
@@ -65,6 +65,7 @@ static int inject_delay;
static bool inject_hwpars_err;
static bool inject_prepare_err;
static bool inject_trigger_err;
+static bool inject_open_err;

static short fill_mode = FILL_MODE_PAT;

@@ -88,6 +89,9 @@ module_param(inject_prepare_err, bool, 0600);
MODULE_PARM_DESC(inject_prepare_err, "Inject EINVAL error in the 'prepare' callback");
module_param(inject_trigger_err, bool, 0600);
MODULE_PARM_DESC(inject_trigger_err, "Inject EINVAL error in the 'trigger' callback");
+module_param(inject_open_err, bool, 0600);
+MODULE_PARM_DESC(inject_open_err, "Inject EBUSY error in the 'open' callback");
+

struct pcmtst {
struct snd_pcm *pcm;
@@ -364,6 +368,9 @@ static int snd_pcmtst_pcm_open(struct snd_pcm_substream *substream)
struct snd_pcm_runtime *runtime = substream->runtime;
struct pcmtst_buf_iter *v_iter;

+ if (inject_open_err)
+ return -EBUSY;
+
v_iter = kzalloc(sizeof(*v_iter), GFP_KERNEL);
if (!v_iter)
return -ENOMEM;
--
2.34.1



2023-07-14 06:40:45

by Takashi Iwai

[permalink] [raw]
Subject: Re: [PATCH v2 1/2] ALSA: pcmtest: Add 'open' PCM callback error injection

On Thu, 13 Jul 2023 09:59:52 +0200,
Ivan Orlov wrote:
>
> Extend 'pcmtest' virtual driver with 'open' callback error injection
> functionality, as it already can inject errors into other PCM callbacks.
> Add module parameter which enables EBUSY error injection in the 'open'
> PCM callback.
>
> Signed-off-by: Ivan Orlov <[email protected]>
> ---
> V1 -> V2:
> - Split changes in the patch into two different patches

Applied both patches now. Thanks.


Takashi