2023-06-23 15:58:38

by Arnd Bergmann

Subject: [PATCH] leds: simatic-ipc-leds-gpio: restore LEDS_CLASS dependency

From: Arnd Bergmann <[email protected]>

A recent rework accidentally lost the dependency on LEDS_CLASS, which
leads to a link error when LED support is disbled:

x86_64-linux-ld: drivers/leds/simple/simatic-ipc-leds.o: in function `simatic_ipc_leds_probe':
simatic-ipc-leds.c:(.text+0x10c): undefined reference to `devm_led_classdev_register_ext'

Add back the dependency that was there originally.

Fixes: a6c80bec3c935 ("leds: simatic-ipc-leds-gpio: Add GPIO version of Siemens driver")
Signed-off-by: Arnd Bergmann <[email protected]>
---
drivers/leds/simple/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/leds/simple/Kconfig b/drivers/leds/simple/Kconfig
index 44fa0f93cb3b3..02443e745ff3b 100644
--- a/drivers/leds/simple/Kconfig
+++ b/drivers/leds/simple/Kconfig
@@ -1,6 +1,7 @@
# SPDX-License-Identifier: GPL-2.0-only
config LEDS_SIEMENS_SIMATIC_IPC
tristate "LED driver for Siemens Simatic IPCs"
+ depends on LEDS_CLASS
depends on SIEMENS_SIMATIC_IPC
help
This option enables support for the LEDs of several Industrial PCs
--
2.39.2

2023-07-13 09:41:19

by Lee Jones

Subject: Re: [PATCH] leds: simatic-ipc-leds-gpio: restore LEDS_CLASS dependency

On Fri, 23 Jun 2023, Arnd Bergmann wrote:

> From: Arnd Bergmann <[email protected]>
>
> A recent rework accidentally lost the dependency on LEDS_CLASS, which
> leads to a link error when LED support is disbled:
>
> x86_64-linux-ld: drivers/leds/simple/simatic-ipc-leds.o: in function `simatic_ipc_leds_probe':
> simatic-ipc-leds.c:(.text+0x10c): undefined reference to `devm_led_classdev_register_ext'
>
> Add back the dependency that was there originally.
>
> Fixes: a6c80bec3c935 ("leds: simatic-ipc-leds-gpio: Add GPIO version of Siemens driver")
> Signed-off-by: Arnd Bergmann <[email protected]>
> ---
> drivers/leds/simple/Kconfig | 1 +
> 1 file changed, 1 insertion(+)

Applied, thanks

--
Lee Jones [李琼斯]