2023-07-13 09:59:32

by Wang Ming

[permalink] [raw]
Subject: [PATCH net v2] bna: Remove error checking for debugfs_create_dir()

It is expected that most callers should _ignore_ the errors return by
debugfs_create_dir() in bnad_debugfs_init().

Signed-off-by: Wang Ming <[email protected]>
---
drivers/net/ethernet/brocade/bna/bnad_debugfs.c | 5 -----
1 file changed, 5 deletions(-)

diff --git a/drivers/net/ethernet/brocade/bna/bnad_debugfs.c b/drivers/net/ethernet/brocade/bna/bnad_debugfs.c
index 04ad0f2b9677..7246e13dd559 100644
--- a/drivers/net/ethernet/brocade/bna/bnad_debugfs.c
+++ b/drivers/net/ethernet/brocade/bna/bnad_debugfs.c
@@ -512,11 +512,6 @@ bnad_debugfs_init(struct bnad *bnad)
if (!bnad->port_debugfs_root) {
bnad->port_debugfs_root =
debugfs_create_dir(name, bna_debugfs_root);
- if (!bnad->port_debugfs_root) {
- netdev_warn(bnad->netdev,
- "debugfs root dir creation failed\n");
- return;
- }

atomic_inc(&bna_debugfs_port_count);

--
2.25.1



2023-07-14 08:59:06

by patchwork-bot+netdevbpf

[permalink] [raw]
Subject: Re: [PATCH net v2] bna: Remove error checking for debugfs_create_dir()

Hello:

This patch was applied to netdev/net.git (main)
by David S. Miller <[email protected]>:

On Thu, 13 Jul 2023 17:51:06 +0800 you wrote:
> It is expected that most callers should _ignore_ the errors return by
> debugfs_create_dir() in bnad_debugfs_init().
>
> Signed-off-by: Wang Ming <[email protected]>
> ---
> drivers/net/ethernet/brocade/bna/bnad_debugfs.c | 5 -----
> 1 file changed, 5 deletions(-)

Here is the summary with links:
- [net,v2] bna: Remove error checking for debugfs_create_dir()
https://git.kernel.org/netdev/net/c/4ad23d2368cc

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html