2023-07-04 10:25:30

by 李扬韬

Subject: [PATCH] leds: ip30: Convert to devm_platform_ioremap_resource()

Use devm_platform_ioremap_resource() to simplify code.

Signed-off-by: Yangtao Li <[email protected]>
---
drivers/leds/leds-ip30.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/drivers/leds/leds-ip30.c b/drivers/leds/leds-ip30.c
index 1f952bad0fe8..2df24c303366 100644
--- a/drivers/leds/leds-ip30.c
+++ b/drivers/leds/leds-ip30.c
@@ -27,22 +27,16 @@ static void ip30led_set(struct led_classdev *led_cdev,

static int ip30led_create(struct platform_device *pdev, int num)
{
- struct resource *res;
struct ip30_led *data;

- res = platform_get_resource(pdev, IORESOURCE_MEM, num);
- if (!res)
- return -EBUSY;
-
data = devm_kzalloc(&pdev->dev, sizeof(*data), GFP_KERNEL);
if (!data)
return -ENOMEM;

- data->reg = devm_ioremap_resource(&pdev->dev, res);
+ data->reg = devm_platform_ioremap_resource(pdev, num);
if (IS_ERR(data->reg))
return PTR_ERR(data->reg);

-
switch (num) {
case IP30_LED_SYSTEM:
data->cdev.name = "white:power";
--
2.39.0

2023-07-13 10:53:05

by Lee Jones

Subject: Re: [PATCH] leds: ip30: Convert to devm_platform_ioremap_resource()

On Tue, 04 Jul 2023, Yangtao Li wrote:

> Use devm_platform_ioremap_resource() to simplify code.
>
> Signed-off-by: Yangtao Li <[email protected]>
> ---
> drivers/leds/leds-ip30.c | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/drivers/leds/leds-ip30.c b/drivers/leds/leds-ip30.c
> index 1f952bad0fe8..2df24c303366 100644
> --- a/drivers/leds/leds-ip30.c
> +++ b/drivers/leds/leds-ip30.c
> @@ -27,22 +27,16 @@ static void ip30led_set(struct led_classdev *led_cdev,
>
> static int ip30led_create(struct platform_device *pdev, int num)
> {
> - struct resource *res;
> struct ip30_led *data;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, num);
> - if (!res)
> - return -EBUSY;
> -
> data = devm_kzalloc(&pdev->dev, sizeof(*data), GFP_KERNEL);
> if (!data)
> return -ENOMEM;
>
> - data->reg = devm_ioremap_resource(&pdev->dev, res);
> + data->reg = devm_platform_ioremap_resource(pdev, num);
> if (IS_ERR(data->reg))
> return PTR_ERR(data->reg);
>
> -

You're not supposed to do that. Separate patch in future please.

But I cannot review what I do not see!

Applied, thanks

--
Lee Jones [李琼斯]