2023-07-13 12:14:47

by Zhen Lei

Subject: [PATCH] arm64: vdso: Clear common make C=2 warnings

make C=2 ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- xxx.o

When I use the command above to do a 'make C=2' check on any object file,
the following warnings are always output:

CHECK arch/arm64/kernel/vdso/vgettimeofday.c
arch/arm64/kernel/vdso/vgettimeofday.c:9:5: warning:
symbol '__kernel_clock_gettime' was not declared. Should it be static?
arch/arm64/kernel/vdso/vgettimeofday.c:15:5: warning:
symbol '__kernel_gettimeofday' was not declared. Should it be static?
arch/arm64/kernel/vdso/vgettimeofday.c:21:5: warning:
symbol '__kernel_clock_getres' was not declared. Should it be static?

Therefore, the declaration of the three functions is added to eliminate
these common warnings to provide a clean output.

Signed-off-by: Zhen Lei <[email protected]>
---
arch/arm64/kernel/vdso/vgettimeofday.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/arch/arm64/kernel/vdso/vgettimeofday.c b/arch/arm64/kernel/vdso/vgettimeofday.c
index 4236cf34d7d9c34..9941c5b04f15878 100644
--- a/arch/arm64/kernel/vdso/vgettimeofday.c
+++ b/arch/arm64/kernel/vdso/vgettimeofday.c
@@ -6,6 +6,10 @@
*
*/

+int __kernel_clock_gettime(clockid_t clock, struct __kernel_timespec *ts);
+int __kernel_gettimeofday(struct __kernel_old_timeval *tv, struct timezone *tz);
+int __kernel_clock_getres(clockid_t clock_id, struct __kernel_timespec *res);
+
int __kernel_clock_gettime(clockid_t clock,
struct __kernel_timespec *ts)
{
--
2.25.1

2023-07-20 12:34:27

by Will Deacon

Subject: Re: [PATCH] arm64: vdso: Clear common make C=2 warnings

On Thu, 13 Jul 2023 19:58:31 +0800, Zhen Lei wrote:
> make C=2 ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- xxx.o
>
> When I use the command above to do a 'make C=2' check on any object file,
> the following warnings are always output:
>
> CHECK arch/arm64/kernel/vdso/vgettimeofday.c
> arch/arm64/kernel/vdso/vgettimeofday.c:9:5: warning:
> symbol '__kernel_clock_gettime' was not declared. Should it be static?
> arch/arm64/kernel/vdso/vgettimeofday.c:15:5: warning:
> symbol '__kernel_gettimeofday' was not declared. Should it be static?
> arch/arm64/kernel/vdso/vgettimeofday.c:21:5: warning:
> symbol '__kernel_clock_getres' was not declared. Should it be static?
>
> [...]

Applied to arm64 (for-next/fixes), thanks!

[1/1] arm64: vdso: Clear common make C=2 warnings
https://git.kernel.org/arm64/c/71e06e1acecb

Cheers,
--
Will

https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev