2023-07-13 12:13:36

by Miaohe Lin

Subject: [PATCH] mm/huge_memory: use RMAP_NONE when calling page_add_anon_rmap()

It's more convenient and readable to use RMAP_NONE instead of false when
calling page_add_anon_rmap(). No functional change intended.

Signed-off-by: Miaohe Lin <[email protected]>
---
mm/huge_memory.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/huge_memory.c b/mm/huge_memory.c
index 9f3109ed7351..762be2f4244c 100644
--- a/mm/huge_memory.c
+++ b/mm/huge_memory.c
@@ -2255,7 +2255,7 @@ static void __split_huge_pmd_locked(struct vm_area_struct *vma, pmd_t *pmd,
entry = pte_mksoft_dirty(entry);
if (uffd_wp)
entry = pte_mkuffd_wp(entry);
- page_add_anon_rmap(page + i, vma, addr, false);
+ page_add_anon_rmap(page + i, vma, addr, RMAP_NONE);
}
VM_BUG_ON(!pte_none(ptep_get(pte)));
set_pte_at(mm, addr, pte, entry);
--
2.33.0

2023-07-13 12:35:23

by Matthew Wilcox

Subject: Re: [PATCH] mm/huge_memory: use RMAP_NONE when calling page_add_anon_rmap()

On Thu, Jul 13, 2023 at 08:05:57PM +0800, Miaohe Lin wrote:
> It's more convenient and readable to use RMAP_NONE instead of false when
> calling page_add_anon_rmap(). No functional change intended.
>
> Signed-off-by: Miaohe Lin <[email protected]>

Reviewed-by: Matthew Wilcox (Oracle) <[email protected]>

2023-07-14 03:49:01

by Anshuman Khandual

Subject: Re: [PATCH] mm/huge_memory: use RMAP_NONE when calling page_add_anon_rmap()

On 7/13/23 17:35, Miaohe Lin wrote:
> It's more convenient and readable to use RMAP_NONE instead of false when
> calling page_add_anon_rmap(). No functional change intended.

It's not only more convenient, page_add_anon_rmap() also expects rmap_t
as the last argument.

>
> Signed-off-by: Miaohe Lin <[email protected]>
> ---
> mm/huge_memory.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/huge_memory.c b/mm/huge_memory.c
> index 9f3109ed7351..762be2f4244c 100644
> --- a/mm/huge_memory.c
> +++ b/mm/huge_memory.c
> @@ -2255,7 +2255,7 @@ static void __split_huge_pmd_locked(struct vm_area_struct *vma, pmd_t *pmd,
> entry = pte_mksoft_dirty(entry);
> if (uffd_wp)
> entry = pte_mkuffd_wp(entry);
> - page_add_anon_rmap(page + i, vma, addr, false);
> + page_add_anon_rmap(page + i, vma, addr, RMAP_NONE);
> }
> VM_BUG_ON(!pte_none(ptep_get(pte)));
> set_pte_at(mm, addr, pte, entry);

After this change, no other page_add_anon_rmap() call site has non rmap_t
argument.

Reviewed-by: Anshuman Khandual <[email protected]>

2023-07-14 14:53:58

by David Hildenbrand

Subject: Re: [PATCH] mm/huge_memory: use RMAP_NONE when calling page_add_anon_rmap()

On 13.07.23 14:05, Miaohe Lin wrote:
> It's more convenient and readable to use RMAP_NONE instead of false when
> calling page_add_anon_rmap(). No functional change intended.
>
> Signed-off-by: Miaohe Lin <[email protected]>
> ---
> mm/huge_memory.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/huge_memory.c b/mm/huge_memory.c
> index 9f3109ed7351..762be2f4244c 100644
> --- a/mm/huge_memory.c
> +++ b/mm/huge_memory.c
> @@ -2255,7 +2255,7 @@ static void __split_huge_pmd_locked(struct vm_area_struct *vma, pmd_t *pmd,
> entry = pte_mksoft_dirty(entry);
> if (uffd_wp)
> entry = pte_mkuffd_wp(entry);
> - page_add_anon_rmap(page + i, vma, addr, false);
> + page_add_anon_rmap(page + i, vma, addr, RMAP_NONE);
> }
> VM_BUG_ON(!pte_none(ptep_get(pte)));
> set_pte_at(mm, addr, pte, entry);

Indeed

Reviewed-by: David Hildenbrand <[email protected]>

--
Cheers,

David / dhildenb