2023-07-13 12:46:54

by Miaohe Lin

Subject: [PATCH] mm/memcg: fix obsolete comment above MEM_CGROUP_MAX_RECLAIM_LOOPS

Since commit 5660048ccac8 ("mm: move memcg hierarchy reclaim to generic
reclaim code"), mem_cgroup_hierarchical_reclaim() is already renamed to
mem_cgroup_soft_reclaim(). Update the corresponding comment.

Signed-off-by: Miaohe Lin <[email protected]>
---
mm/memcontrol.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index 3eaeb69ef9f5..93e3cc581b51 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -197,7 +197,7 @@ static struct move_charge_struct {
};

/*
- * Maximum loops in mem_cgroup_hierarchical_reclaim(), used for soft
+ * Maximum loops in mem_cgroup_soft_reclaim(), used for soft
* limit reclaim to prevent infinite loops, if they ever occur.
*/
#define MEM_CGROUP_MAX_RECLAIM_LOOPS 100
--
2.33.0

2023-07-13 13:35:30

by Muchun Song

Subject: Re: [PATCH] mm/memcg: fix obsolete comment above MEM_CGROUP_MAX_RECLAIM_LOOPS

> On Jul 13, 2023, at 20:14, Miaohe Lin <[email protected]> wrote:
>
> Since commit 5660048ccac8 ("mm: move memcg hierarchy reclaim to generic
> reclaim code"), mem_cgroup_hierarchical_reclaim() is already renamed to
> mem_cgroup_soft_reclaim(). Update the corresponding comment.
>
> Signed-off-by: Miaohe Lin <[email protected]>

Reviewed-by: Muchun Song <[email protected]>

Thanks.