2023-07-14 08:07:10

by huzhi001

Subject: [PATCH] VFS: Fix seven errors in bitmap.c

The following checkpatch errors are removed:
ERROR: space required after that ',' (ctx:VxV)
ERROR: space required after that ',' (ctx:VxV)
ERROR: space required after that ',' (ctx:VxV)
ERROR: space required after that ',' (ctx:VxV)
ERROR: space required after that ',' (ctx:VxV)
ERROR: space required after that ',' (ctx:VxV)
ERROR: space required after that ',' (ctx:VxV)

Signed-off-by: ZhiHu <[email protected]>
---
fs/affs/bitmap.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/fs/affs/bitmap.c b/fs/affs/bitmap.c
index 5ba9ef2742f6..b1620b6ff8a9 100644
--- a/fs/affs/bitmap.c
+++ b/fs/affs/bitmap.c
@@ -87,19 +87,19 @@ affs_free_block(struct super_block *sb, u32 block)
return;

err_free:
- affs_warning(sb,"affs_free_block","Trying to free block %u which is
already free", block);
+ affs_warning(sb, "affs_free_block", "Trying to free block %u which
is already free", block);
mutex_unlock(&sbi->s_bmlock);
return;

err_bh_read:
- affs_error(sb,"affs_free_block","Cannot read bitmap block %u",
bm->bm_key);
+ affs_error(sb, "affs_free_block", "Cannot read bitmap block %u",
bm->bm_key);
sbi->s_bmap_bh = NULL;
sbi->s_last_bmap = ~0;
mutex_unlock(&sbi->s_bmlock);
return;

err_range:
- affs_error(sb, "affs_free_block","Block %u outside partition",
block);
+ affs_error(sb, "affs_free_block", "Block %u outside partition",
block);
}

/*
@@ -232,7 +232,7 @@ affs_alloc_block(struct inode *inode, u32 goal)
return blk;

err_bh_read:
- affs_error(sb,"affs_read_block","Cannot read bitmap block %u",
bm->bm_key);
+ affs_error(sb, "affs_read_block", "Cannot read bitmap block %u",
bm->bm_key);
sbi->s_bmap_bh = NULL;
sbi->s_last_bmap = ~0;
err_full:

2023-07-14 11:21:44

by David Sterba

Subject: Re: [PATCH] VFS: Fix seven errors in bitmap.c

On Fri, Jul 14, 2023 at 03:14:18PM +0800, [email protected] wrote:
> The following checkpatch errors are removed:
> ERROR: space required after that ',' (ctx:VxV)
> ERROR: space required after that ',' (ctx:VxV)
> ERROR: space required after that ',' (ctx:VxV)
> ERROR: space required after that ',' (ctx:VxV)
> ERROR: space required after that ',' (ctx:VxV)
> ERROR: space required after that ',' (ctx:VxV)
> ERROR: space required after that ',' (ctx:VxV)

The AFFS module gets only bug fixes (as can be seen in the MAINTAINERS
file) or API updates, not coding style fixes.

The sources have way more stylistic things that checkpatch does not like
but we are not going to fix them:

total: 0 errors, 1 warnings, 189 lines checked
total: 1 errors, 5 warnings, 543 lines checked
total: 7 errors, 4 warnings, 365 lines checked
total: 1 errors, 1 warnings, 144 lines checked
total: 2 errors, 13 warnings, 1009 lines checked
total: 8 errors, 12 warnings, 422 lines checked
total: 0 errors, 2 warnings, 584 lines checked
total: 15 errors, 13 warnings, 681 lines checked
total: 1 errors, 2 warnings, 77 lines checked
total: 4 errors, 10 warnings, 328 lines checked
total: 4 errors, 0 warnings, 148 lines checked