2023-07-14 15:56:34

by Thierry Reding

Subject: [PATCH] memory: tegra: Prefer octal over symbolic permissions

From: Thierry Reding <[email protected]>

checkpatch recommends using octal permissions instead of symbolic
permissions. Switch the debugfs files to use the former to silence
these warnings.

Signed-off-by: Thierry Reding <[email protected]>
---
drivers/memory/tegra/tegra186-emc.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/memory/tegra/tegra186-emc.c b/drivers/memory/tegra/tegra186-emc.c
index 83981ae3ea86..4007f4e16d74 100644
--- a/drivers/memory/tegra/tegra186-emc.c
+++ b/drivers/memory/tegra/tegra186-emc.c
@@ -212,12 +212,12 @@ static int tegra186_emc_get_emc_dvfs_latency(struct tegra186_emc *emc)
}

emc->debugfs.root = debugfs_create_dir("emc", NULL);
- debugfs_create_file("available_rates", S_IRUGO, emc->debugfs.root,
- emc, &tegra186_emc_debug_available_rates_fops);
- debugfs_create_file("min_rate", S_IRUGO | S_IWUSR, emc->debugfs.root,
- emc, &tegra186_emc_debug_min_rate_fops);
- debugfs_create_file("max_rate", S_IRUGO | S_IWUSR, emc->debugfs.root,
- emc, &tegra186_emc_debug_max_rate_fops);
+ debugfs_create_file("available_rates", 0444, emc->debugfs.root, emc,
+ &tegra186_emc_debug_available_rates_fops);
+ debugfs_create_file("min_rate", 0644, emc->debugfs.root, emc,
+ &tegra186_emc_debug_min_rate_fops);
+ debugfs_create_file("max_rate", 0644, emc->debugfs.root, emc,
+ &tegra186_emc_debug_max_rate_fops);

return 0;
}
--
2.41.0

2023-07-18 19:11:06

by Krzysztof Kozlowski

Subject: Re: [PATCH] memory: tegra: Prefer octal over symbolic permissions

On Fri, 14 Jul 2023 17:01:16 +0200, Thierry Reding wrote:
> checkpatch recommends using octal permissions instead of symbolic
> permissions. Switch the debugfs files to use the former to silence
> these warnings.
>
>

Applied, thanks!

[1/1] memory: tegra: Prefer octal over symbolic permissions
https://git.kernel.org/krzk/linux-mem-ctrl/c/f54abe0132e405cd482b8cad355cd680e3aec810

Best regards,
--
Krzysztof Kozlowski <[email protected]>