2023-07-15 03:14:21

by Miaohe Lin

Subject: [PATCH] cgroup: use cached local variable parent in for loop

Use local variable parent to initialize iter tcgrp in for loop so the size
of cgroup.o can be reduced by 64 bytes. No functional change intended.

Signed-off-by: Miaohe Lin <[email protected]>
---
kernel/cgroup/cgroup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c
index 6225d5829459..033f38fb5cef 100644
--- a/kernel/cgroup/cgroup.c
+++ b/kernel/cgroup/cgroup.c
@@ -5894,7 +5894,7 @@ static int cgroup_destroy_locked(struct cgroup *cgrp)
parent->nr_threaded_children--;

spin_lock_irq(&css_set_lock);
- for (tcgrp = cgroup_parent(cgrp); tcgrp; tcgrp = cgroup_parent(tcgrp)) {
+ for (tcgrp = parent; tcgrp; tcgrp = cgroup_parent(tcgrp)) {
tcgrp->nr_descendants--;
tcgrp->nr_dying_descendants++;
/*
--
2.33.0

2023-07-17 18:55:55

by Tejun Heo

Subject: Re: [PATCH] cgroup: use cached local variable parent in for loop

On Sat, Jul 15, 2023 at 11:08:29AM +0800, Miaohe Lin wrote:
> Use local variable parent to initialize iter tcgrp in for loop so the size
> of cgroup.o can be reduced by 64 bytes. No functional change intended.
>
> Signed-off-by: Miaohe Lin <[email protected]>

Applied to cgroup/for-6.6.

Thanks.

--
tejun