2023-07-15 03:48:52

by Yang Jihong

Subject: [PATCH v2 7/7] perf test: Add test case for record sideband events

Add a new test case to record sideband events for all CPUs when tracing
selected CPUs

Test result:

# ./perf test list 2>&1 | grep 'perf record sideband tests'
95: perf record sideband tests
# ./perf test 95
95: perf record sideband tests : Ok

Signed-off-by: Yang Jihong <[email protected]>
---
tools/perf/tests/shell/record_tracking.sh | 44 +++++++++++++++++++++++
1 file changed, 44 insertions(+)
create mode 100755 tools/perf/tests/shell/record_tracking.sh

diff --git a/tools/perf/tests/shell/record_tracking.sh b/tools/perf/tests/shell/record_tracking.sh
new file mode 100755
index 000000000000..44fc0af92f81
--- /dev/null
+++ b/tools/perf/tests/shell/record_tracking.sh
@@ -0,0 +1,44 @@
+#!/bin/sh
+# perf record sideband tests
+# SPDX-License-Identifier: GPL-2.0
+
+set -e
+
+err=0
+perfdata=$(mktemp /tmp/__perf_test.perf.data.XXXXX)
+
+can_cpu_wide()
+{
+ if ! perf record -o ${perfdata} -BN --no-bpf-event -e dummy:u -C $1 true 2>&1 >/dev/null
+ then
+ echo "record sideband test [Skipped cannot record cpu$1]"
+ err=2
+ fi
+
+ rm -f ${perfdata}
+ return $err
+}
+
+test_system_wide_tracking()
+{
+ # Need CPU 0 and CPU 1
+ can_cpu_wide 0 || return 0
+ can_cpu_wide 1 || return 0
+
+ # Record on CPU 0 a task running on CPU 1
+ perf record -BN --no-bpf-event -o ${perfdata} -e dummy:u -C 0 -- taskset --cpu-list 1 true
+
+ # Should get MMAP events from CPU 1
+ mmap_cnt=`perf script -i ${perfdata} --show-mmap-events -C 1 2>/dev/null | grep MMAP | wc -l`
+
+ rm -f ${perfdata}
+
+ if [ ${mmap_cnt} -gt 0 ] ; then
+ return 0
+ fi
+
+ echo "Failed to record MMAP events on CPU 1 when tracing CPU 0"
+ return 1
+}
+
+test_system_wide_tracking
--
2.30.GIT

2023-07-19 17:22:14

by Ian Rogers

Subject: Re: [PATCH v2 7/7] perf test: Add test case for record sideband events

On Fri, Jul 14, 2023 at 8:31 PM Yang Jihong <[email protected]> wrote:
>
> Add a new test case to record sideband events for all CPUs when tracing
> selected CPUs
>
> Test result:
>
> # ./perf test list 2>&1 | grep 'perf record sideband tests'
> 95: perf record sideband tests
> # ./perf test 95
> 95: perf record sideband tests : Ok
>
> Signed-off-by: Yang Jihong <[email protected]>
> ---
> tools/perf/tests/shell/record_tracking.sh | 44 +++++++++++++++++++++++
> 1 file changed, 44 insertions(+)
> create mode 100755 tools/perf/tests/shell/record_tracking.sh
>
> diff --git a/tools/perf/tests/shell/record_tracking.sh b/tools/perf/tests/shell/record_tracking.sh

Could this be record_sideband.sh ? It will be more consistent with the
test output...

Thanks,
Ian

> new file mode 100755
> index 000000000000..44fc0af92f81
> --- /dev/null
> +++ b/tools/perf/tests/shell/record_tracking.sh
> @@ -0,0 +1,44 @@
> +#!/bin/sh
> +# perf record sideband tests
> +# SPDX-License-Identifier: GPL-2.0
> +
> +set -e
> +
> +err=0
> +perfdata=$(mktemp /tmp/__perf_test.perf.data.XXXXX)
> +
> +can_cpu_wide()
> +{
> + if ! perf record -o ${perfdata} -BN --no-bpf-event -e dummy:u -C $1 true 2>&1 >/dev/null
> + then
> + echo "record sideband test [Skipped cannot record cpu$1]"
> + err=2
> + fi
> +
> + rm -f ${perfdata}
> + return $err
> +}
> +
> +test_system_wide_tracking()
> +{
> + # Need CPU 0 and CPU 1
> + can_cpu_wide 0 || return 0
> + can_cpu_wide 1 || return 0
> +
> + # Record on CPU 0 a task running on CPU 1
> + perf record -BN --no-bpf-event -o ${perfdata} -e dummy:u -C 0 -- taskset --cpu-list 1 true
> +
> + # Should get MMAP events from CPU 1
> + mmap_cnt=`perf script -i ${perfdata} --show-mmap-events -C 1 2>/dev/null | grep MMAP | wc -l`
> +
> + rm -f ${perfdata}
> +
> + if [ ${mmap_cnt} -gt 0 ] ; then
> + return 0
> + fi
> +
> + echo "Failed to record MMAP events on CPU 1 when tracing CPU 0"
> + return 1
> +}
> +
> +test_system_wide_tracking
> --
> 2.30.GIT
>

2023-07-20 08:12:52

by Yang Jihong

Subject: Re: [PATCH v2 7/7] perf test: Add test case for record sideband events

Hello,

On 2023/7/20 0:48, Ian Rogers wrote:
> On Fri, Jul 14, 2023 at 8:31 PM Yang Jihong <[email protected]> wrote:
>>
>> Add a new test case to record sideband events for all CPUs when tracing
>> selected CPUs
>>
>> Test result:
>>
>> # ./perf test list 2>&1 | grep 'perf record sideband tests'
>> 95: perf record sideband tests
>> # ./perf test 95
>> 95: perf record sideband tests : Ok
>>
>> Signed-off-by: Yang Jihong <[email protected]>
>> ---
>> tools/perf/tests/shell/record_tracking.sh | 44 +++++++++++++++++++++++
>> 1 file changed, 44 insertions(+)
>> create mode 100755 tools/perf/tests/shell/record_tracking.sh
>>
>> diff --git a/tools/perf/tests/shell/record_tracking.sh b/tools/perf/tests/shell/record_tracking.sh
>
> Could this be record_sideband.sh ? It will be more consistent with the
> test output...
>
OK, will be changed to "record_sideband.sh" in the next version.

Thanks,
Yang