2023-06-19 15:46:40

by Maksim Kiselev

[permalink] [raw]
Subject: [PATCH v8 1/4] iio: adc: Kconfig change description for Allwinner GPADC

This patch adds SoCs names to Allwinner GPADC description to
make it more informative.

Fixes: d1caa9905538 ("iio: adc: add support for Allwinner SoCs ADC")
Signed-off-by: Maksim Kiselev <[email protected]>
---
drivers/iio/adc/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
index eb2b09ef5d5b..d93868684c7b 100644
--- a/drivers/iio/adc/Kconfig
+++ b/drivers/iio/adc/Kconfig
@@ -1105,7 +1105,7 @@ config STMPE_ADC
built-in ADC block (stmpe811).

config SUN4I_GPADC
- tristate "Support for the Allwinner SoCs GPADC"
+ tristate "Allwinner A10/A13/A31 and similar GPADCs driver"
depends on IIO
depends on MFD_SUN4I_GPADC || MACH_SUN8I
depends on THERMAL || !THERMAL_OF
--
2.39.2



2023-07-11 18:26:54

by Jernej Škrabec

[permalink] [raw]
Subject: Re: [PATCH v8 1/4] iio: adc: Kconfig change description for Allwinner GPADC

Dne ponedeljek, 19. junij 2023 ob 17:42:24 CEST je Maksim Kiselev napisal(a):
> This patch adds SoCs names to Allwinner GPADC description to
> make it more informative.

Please reword to remove "This patch".

>
> Fixes: d1caa9905538 ("iio: adc: add support for Allwinner SoCs ADC")

I'm fine with the patch in general, but does this really warrant fixes tag?

Best regards,
Jernej


> Signed-off-by: Maksim Kiselev <[email protected]>
> ---
> drivers/iio/adc/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> index eb2b09ef5d5b..d93868684c7b 100644
> --- a/drivers/iio/adc/Kconfig
> +++ b/drivers/iio/adc/Kconfig
> @@ -1105,7 +1105,7 @@ config STMPE_ADC
> built-in ADC block (stmpe811).
>
> config SUN4I_GPADC
> - tristate "Support for the Allwinner SoCs GPADC"
> + tristate "Allwinner A10/A13/A31 and similar GPADCs driver"
> depends on IIO
> depends on MFD_SUN4I_GPADC || MACH_SUN8I
> depends on THERMAL || !THERMAL_OF





2023-07-12 06:31:05

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v8 1/4] iio: adc: Kconfig change description for Allwinner GPADC

On 11/07/2023 20:14, Jernej Škrabec wrote:
> Dne ponedeljek, 19. junij 2023 ob 17:42:24 CEST je Maksim Kiselev napisal(a):
>> This patch adds SoCs names to Allwinner GPADC description to
>> make it more informative.
>
> Please reword to remove "This patch".
>
>>
>> Fixes: d1caa9905538 ("iio: adc: add support for Allwinner SoCs ADC")
>
> I'm fine with the patch in general, but does this really warrant fixes tag?
>

No, it's some fake fix. There is no bug here.

Best regards,
Krzysztof


2023-07-15 17:10:41

by Jonathan Cameron

[permalink] [raw]
Subject: Re: [PATCH v8 1/4] iio: adc: Kconfig change description for Allwinner GPADC

On Wed, 12 Jul 2023 07:37:38 +0200
Krzysztof Kozlowski <[email protected]> wrote:

> On 11/07/2023 20:14, Jernej Škrabec wrote:
> > Dne ponedeljek, 19. junij 2023 ob 17:42:24 CEST je Maksim Kiselev napisal(a):
> >> This patch adds SoCs names to Allwinner GPADC description to
> >> make it more informative.
> >
> > Please reword to remove "This patch".
> >
> >>
> >> Fixes: d1caa9905538 ("iio: adc: add support for Allwinner SoCs ADC")
> >
> > I'm fine with the patch in general, but does this really warrant fixes tag?
> >
>
> No, it's some fake fix. There is no bug here.
>
> Best regards,
> Krzysztof
>

Dropped the tag.

Thanks for pointing this out.

Jonathan