2023-07-19 15:29:46

by Eric Van Hensbergen

Subject: [PATCH v3 2/4] fs/9p: fix typo in comparison logic for cache mode

There appears to be a typo in the comparison statement for the logic
which sets a file's cache mode based on mount flags.

Fixes: 1543b4c5071c ("fs/9p: remove writeback fid and fix per-file modes")
Link: https://lore.kernel.org/v9fs/ZK25XZ%2BGpR3KHIB%[email protected]/
Reviewed-by: Christian Schoenebeck <[email protected]>
Reviewed-by: Dominique Martinet <[email protected]>
Signed-off-by: Eric Van Hensbergen <[email protected]>
---
fs/9p/fid.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/9p/fid.h b/fs/9p/fid.h
index 0c51889a60b3..297c2c377e3d 100644
--- a/fs/9p/fid.h
+++ b/fs/9p/fid.h
@@ -57,7 +57,7 @@ static inline void v9fs_fid_add_modes(struct p9_fid *fid, int s_flags,
(s_flags & V9FS_DIRECT_IO) || (f_flags & O_DIRECT)) {
fid->mode |= P9L_DIRECT; /* no read or write cache */
} else if ((!(s_cache & CACHE_WRITEBACK)) ||
- (f_flags & O_DSYNC) | (s_flags & V9FS_SYNC)) {
+ (f_flags & O_DSYNC) || (s_flags & V9FS_SYNC)) {
fid->mode |= P9L_NOWRITECACHE;
}
}

--
2.39.2

2023-07-19 16:31:54

by Greg Kroah-Hartman

Subject: Re: [PATCH v3 2/4] fs/9p: fix typo in comparison logic for cache mode

On Wed, Jul 19, 2023 at 03:17:06PM +0000, Eric Van Hensbergen wrote:
> There appears to be a typo in the comparison statement for the logic
> which sets a file's cache mode based on mount flags.
>
> Fixes: 1543b4c5071c ("fs/9p: remove writeback fid and fix per-file modes")
> Link: https://lore.kernel.org/v9fs/ZK25XZ%2BGpR3KHIB%[email protected]/
> Reviewed-by: Christian Schoenebeck <[email protected]>
> Reviewed-by: Dominique Martinet <[email protected]>
> Signed-off-by: Eric Van Hensbergen <[email protected]>
> ---
> fs/9p/fid.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>

<formletter>

This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.

</formletter>