2023-07-17 07:33:21

by Wu Yunchuan

[permalink] [raw]
Subject: [PATCH net-next v4 8/9] can: ems_pci: Remove unnecessary (void*) conversions

No need cast (void*) to (struct ems_pci_card *).

Acked-by: Marc Kleine-Budde <[email protected]>
Signed-off-by: Wu Yunchuan <[email protected]>
---
drivers/net/can/sja1000/ems_pci.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/can/sja1000/ems_pci.c b/drivers/net/can/sja1000/ems_pci.c
index c56e27223e5f..ac86640998a8 100644
--- a/drivers/net/can/sja1000/ems_pci.c
+++ b/drivers/net/can/sja1000/ems_pci.c
@@ -148,7 +148,7 @@ static void ems_pci_v1_write_reg(const struct sja1000_priv *priv,

static void ems_pci_v1_post_irq(const struct sja1000_priv *priv)
{
- struct ems_pci_card *card = (struct ems_pci_card *)priv->priv;
+ struct ems_pci_card *card = priv->priv;

/* reset int flag of pita */
writel(PITA2_ICR_INT0_EN | PITA2_ICR_INT0,
@@ -168,7 +168,7 @@ static void ems_pci_v2_write_reg(const struct sja1000_priv *priv,

static void ems_pci_v2_post_irq(const struct sja1000_priv *priv)
{
- struct ems_pci_card *card = (struct ems_pci_card *)priv->priv;
+ struct ems_pci_card *card = priv->priv;

writel(PLX_ICSR_ENA_CLR, card->conf_addr + PLX_ICSR);
}
@@ -186,7 +186,7 @@ static void ems_pci_v3_write_reg(const struct sja1000_priv *priv,

static void ems_pci_v3_post_irq(const struct sja1000_priv *priv)
{
- struct ems_pci_card *card = (struct ems_pci_card *)priv->priv;
+ struct ems_pci_card *card = priv->priv;

writel(ASIX_LINTSR_INT0AC, card->conf_addr + ASIX_LINTSR);
}
--
2.30.2



2023-07-17 15:37:21

by Marc Kleine-Budde

[permalink] [raw]
Subject: Re: [PATCH net-next v4 8/9] can: ems_pci: Remove unnecessary (void*) conversions

On 17.07.2023 15:18:01, Wu Yunchuan wrote:
> No need cast (void*) to (struct ems_pci_card *).
>
> Acked-by: Marc Kleine-Budde <[email protected]>
> Signed-off-by: Wu Yunchuan <[email protected]>

Applied to linux-can-next/testing.

Thanks,
Marc

--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung Nürnberg | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |


Attachments:
(No filename) (529.00 B)
signature.asc (499.00 B)
Download all attachments