2023-07-17 13:40:44

by zhangpeng (AS)

Subject: [PATCH 3/6] mm/page_io: use a folio in swap_writepage_bdev_sync()

From: ZhangPeng <[email protected]>

Saves one implicit call to compound_head().

Signed-off-by: ZhangPeng <[email protected]>
---
mm/page_io.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/mm/page_io.c b/mm/page_io.c
index 438d0c7c2194..f24f814b8dca 100644
--- a/mm/page_io.c
+++ b/mm/page_io.c
@@ -334,6 +334,7 @@ static void swap_writepage_bdev_sync(struct page *page,
{
struct bio_vec bv;
struct bio bio;
+ struct folio *folio = page_folio(page);

bio_init(&bio, sis->bdev, &bv, 1,
REQ_OP_WRITE | REQ_SWAP | wbc_to_write_flags(wbc));
@@ -343,8 +344,8 @@ static void swap_writepage_bdev_sync(struct page *page,
bio_associate_blkg_from_page(&bio, page);
count_swpout_vm_event(page);

- set_page_writeback(page);
- unlock_page(page);
+ folio_start_writeback(folio);
+ folio_unlock(folio);

submit_bio_wait(&bio);
__end_swap_bio_write(&bio);
--
2.25.1

2023-07-17 15:03:56

by Matthew Wilcox

Subject: Re: [PATCH 3/6] mm/page_io: use a folio in swap_writepage_bdev_sync()

On Mon, Jul 17, 2023 at 09:25:59PM +0800, Peng Zhang wrote:
> From: ZhangPeng <[email protected]>
>
> Saves one implicit call to compound_head().
>
> Signed-off-by: ZhangPeng <[email protected]>

Reviewed-by: Matthew Wilcox (Oracle) <[email protected]>