2023-07-17 21:15:33

by Krzysztof Kozlowski

Subject: [PATCH 1/2] arm64: dts: qcom: sc8180x-primus: remove superfluous "input-enable"

Pin configuration property "input-enable" was used with the intention to
disable the output, but this is done by default by Linux drivers. Since
commit c4a48b0df8bf ("dt-bindings: pinctrl: qcom: tlmm should use
output-disable, not input-enable") the property is not accepted anymore:

sc8180x-primus.dtb: pinctrl@3100000: hall-int-active-state: 'oneOf' conditional failed, one must be fixed:
'bias-disable', 'function', 'input-enable', 'pins' do not match any of the regexes: '-pins$', 'pinctrl-[0-9]+'

Signed-off-by: Krzysztof Kozlowski <[email protected]>

---

That's my favorite commit.
---
arch/arm64/boot/dts/qcom/sc8180x-primus.dts | 5 -----
1 file changed, 5 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sc8180x-primus.dts b/arch/arm64/boot/dts/qcom/sc8180x-primus.dts
index 9b8695b92c48..aaac2da69286 100644
--- a/arch/arm64/boot/dts/qcom/sc8180x-primus.dts
+++ b/arch/arm64/boot/dts/qcom/sc8180x-primus.dts
@@ -580,7 +580,6 @@ hall_int_active_state: hall-int-active-state {
pins = "gpio121";
function = "gpio";

- input-enable;
bias-disable;
};

@@ -590,7 +589,6 @@ int-n-pins {
function = "gpio";

bias-pull-up;
- intput-enable;
};

kp-disable-pins {
@@ -639,7 +637,6 @@ tp-int-pins {
function = "gpio";

bias-disable;
- input-enable;
};

tp-close-n-pins {
@@ -647,7 +644,6 @@ tp-close-n-pins {
function = "gpio";

bias-disable;
- input-enable;
};
};

@@ -656,7 +652,6 @@ int-n-pins {
pins = "gpio122";
function = "gpio";

- input-enable;
bias-disable;
};

--
2.34.1

2023-07-17 21:16:28

by Krzysztof Kozlowski

Subject: [PATCH 2/2] arm64: dts: qcom: sm8250-pdx203: add required pin function

DT bindings expect function in each pin state in the pin configuration:

sm8250-sony-xperia-edo-pdx203.dtb: pinctrl@f100000: cam-pwr-b-state: 'oneOf' conditional failed, one must be fixed:
'function' is a required property

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo-pdx203.dts | 2 ++
1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo-pdx203.dts b/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo-pdx203.dts
index f4c4575eb03b..b70bf9261ba9 100644
--- a/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo-pdx203.dts
+++ b/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo-pdx203.dts
@@ -366,6 +366,7 @@ &tlmm {

cam_pwr_b_cs: cam-pwr-b-state {
pins = "gpio69";
+ function = "gpio";
drive-strength = <2>;
bias-disable;
output-low;
@@ -373,6 +374,7 @@ cam_pwr_b_cs: cam-pwr-b-state {

cam_pwr_a_cs: cam-pwr-a-state {
pins = "gpio71";
+ function = "gpio";
drive-strength = <2>;
bias-disable;
output-low;
--
2.34.1

2023-07-18 05:29:24

by Bjorn Andersson

Subject: Re: (subset) [PATCH 1/2] arm64: dts: qcom: sc8180x-primus: remove superfluous "input-enable"

On Mon, 17 Jul 2023 23:00:54 +0200, Krzysztof Kozlowski wrote:
> Pin configuration property "input-enable" was used with the intention to
> disable the output, but this is done by default by Linux drivers. Since
> commit c4a48b0df8bf ("dt-bindings: pinctrl: qcom: tlmm should use
> output-disable, not input-enable") the property is not accepted anymore:
>
> sc8180x-primus.dtb: pinctrl@3100000: hall-int-active-state: 'oneOf' conditional failed, one must be fixed:
> 'bias-disable', 'function', 'input-enable', 'pins' do not match any of the regexes: '-pins$', 'pinctrl-[0-9]+'
>
> [...]

Applied, thanks!

[1/2] arm64: dts: qcom: sc8180x-primus: remove superfluous "input-enable"
commit: 37e93c7c99e140584be9cacad598a2c3e274ce99
[2/2] arm64: dts: qcom: sm8250-pdx203: add required pin function
commit: 26834b452f40830011294497788bbc82bf1b14af

Best regards,
--
Bjorn Andersson <[email protected]>