2023-07-18 13:00:35

by Julien Panis

Subject: [PATCH] ARM: multi_v7_defconfig: Enable OMAP watchdog support

Add OMAP watchdog support by enabling
CONFIG_OMAP_WATCHDOG as module.

Signed-off-by: Julien Panis <[email protected]>
---
Enable OMAP watchdog support in multi_v7_defconfig.
---
arch/arm/configs/multi_v7_defconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
index f0800f806b5f..7d93e21e0cb9 100644
--- a/arch/arm/configs/multi_v7_defconfig
+++ b/arch/arm/configs/multi_v7_defconfig
@@ -554,6 +554,7 @@ CONFIG_SAMA5D4_WATCHDOG=y
CONFIG_S3C2410_WATCHDOG=m
CONFIG_DW_WATCHDOG=y
CONFIG_DAVINCI_WATCHDOG=m
+CONFIG_OMAP_WATCHDOG=m
CONFIG_ORION_WATCHDOG=y
CONFIG_RN5T618_WATCHDOG=y
CONFIG_SUNXI_WATCHDOG=y

---
base-commit: fdf0eaf11452d72945af31804e2a1048ee1b574c
change-id: 20230718-enable-omap-wd-6a563c280752

Best regards,
--
Julien Panis <[email protected]>

2023-07-18 15:07:58

by Andrew Davis

Subject: Re: [PATCH] ARM: multi_v7_defconfig: Enable OMAP watchdog support

On 7/18/23 7:51 AM, Julien Panis wrote:
> Add OMAP watchdog support by enabling
> CONFIG_OMAP_WATCHDOG as module.
>

Commit messages should describe "why", we can figure out the above
from just looking at the patch.

What boards use this? What does this change on those boards?

Wrap lines at 80-100 chars, not 40..

Andrew

> Signed-off-by: Julien Panis <[email protected]>
> ---
> Enable OMAP watchdog support in multi_v7_defconfig.
> ---
> arch/arm/configs/multi_v7_defconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
> index f0800f806b5f..7d93e21e0cb9 100644
> --- a/arch/arm/configs/multi_v7_defconfig
> +++ b/arch/arm/configs/multi_v7_defconfig
> @@ -554,6 +554,7 @@ CONFIG_SAMA5D4_WATCHDOG=y
> CONFIG_S3C2410_WATCHDOG=m
> CONFIG_DW_WATCHDOG=y
> CONFIG_DAVINCI_WATCHDOG=m
> +CONFIG_OMAP_WATCHDOG=m
> CONFIG_ORION_WATCHDOG=y
> CONFIG_RN5T618_WATCHDOG=y
> CONFIG_SUNXI_WATCHDOG=y
>
> ---
> base-commit: fdf0eaf11452d72945af31804e2a1048ee1b574c
> change-id: 20230718-enable-omap-wd-6a563c280752
>
> Best regards,