2023-07-18 15:40:11

by Michael Riesch

[permalink] [raw]
Subject: [PATCH 0/2] drm/panel: sitronix-st7789v: add panel orientation support

Hi all,

This series adds support for orientation specification in the device
tree to the Sitronix ST7789V panel driver.

This is can be seen as reduced version of [0] (some things of [0] have
been implemented in more general fashion in the scope of [1], other
things have been rejected).

Looking forward to your comments!

[0] https://lore.kernel.org/lkml/[email protected]/
[1] https://lore.kernel.org/lkml/[email protected]/

---
Michael Riesch (2):
drm/panel: sitronix-st7789v: add panel orientation support
dt-bindings: display: add rotation property to sitronix,st7789v

.../bindings/display/panel/sitronix,st7789v.yaml | 2 ++
drivers/gpu/drm/panel/panel-sitronix-st7789v.c | 28 ++++++++++++++++++----
2 files changed, 25 insertions(+), 5 deletions(-)
---
base-commit: 06c2afb862f9da8dc5efa4b6076a0e48c3fbaaa5
change-id: 20230718-feature-st7789v-4d0c2c6e2429

Best regards,
--
Michael Riesch <[email protected]>



2023-07-18 15:44:38

by Michael Riesch

[permalink] [raw]
Subject: [PATCH 2/2] dt-bindings: display: add rotation property to sitronix,st7789v

The sitronix-st7789v driver now considers the rotation property.
Add the property to the documentation.

Signed-off-by: Michael Riesch <[email protected]>
---
Documentation/devicetree/bindings/display/panel/sitronix,st7789v.yaml | 2 ++
1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/display/panel/sitronix,st7789v.yaml b/Documentation/devicetree/bindings/display/panel/sitronix,st7789v.yaml
index fa6556363cca..694d7f771d0c 100644
--- a/Documentation/devicetree/bindings/display/panel/sitronix,st7789v.yaml
+++ b/Documentation/devicetree/bindings/display/panel/sitronix,st7789v.yaml
@@ -22,6 +22,7 @@ properties:
power-supply: true
backlight: true
port: true
+ rotation: true

spi-cpha: true
spi-cpol: true
@@ -52,6 +53,7 @@ examples:
reset-gpios = <&pio 6 11 GPIO_ACTIVE_LOW>;
backlight = <&pwm_bl>;
power-supply = <&power>;
+ rotation = <180>;
spi-max-frequency = <100000>;
spi-cpol;
spi-cpha;

--
2.30.2


2023-07-18 16:10:45

by Conor Dooley

[permalink] [raw]
Subject: Re: [PATCH 2/2] dt-bindings: display: add rotation property to sitronix,st7789v

On Tue, Jul 18, 2023 at 05:12:46PM +0200, Michael Riesch wrote:
> The sitronix-st7789v driver now considers the rotation property.
> Add the property to the documentation.
>
> Signed-off-by: Michael Riesch <[email protected]>

Acked-by: Conor Dooley <[email protected]>

Thanks,
Conor.

> ---
> Documentation/devicetree/bindings/display/panel/sitronix,st7789v.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/panel/sitronix,st7789v.yaml b/Documentation/devicetree/bindings/display/panel/sitronix,st7789v.yaml
> index fa6556363cca..694d7f771d0c 100644
> --- a/Documentation/devicetree/bindings/display/panel/sitronix,st7789v.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/sitronix,st7789v.yaml
> @@ -22,6 +22,7 @@ properties:
> power-supply: true
> backlight: true
> port: true
> + rotation: true
>
> spi-cpha: true
> spi-cpol: true
> @@ -52,6 +53,7 @@ examples:
> reset-gpios = <&pio 6 11 GPIO_ACTIVE_LOW>;
> backlight = <&pwm_bl>;
> power-supply = <&power>;
> + rotation = <180>;
> spi-max-frequency = <100000>;
> spi-cpol;
> spi-cpha;
>
> --
> 2.30.2
>


Attachments:
(No filename) (1.27 kB)
signature.asc (235.00 B)
Download all attachments

2023-08-02 13:19:48

by Michael Riesch

[permalink] [raw]
Subject: Re: [PATCH 0/2] drm/panel: sitronix-st7789v: add panel orientation support

Hi all,

On 7/18/23 17:12, Michael Riesch wrote:
> Hi all,
>
> This series adds support for orientation specification in the device
> tree to the Sitronix ST7789V panel driver.
>
> This is can be seen as reduced version of [0] (some things of [0] have
> been implemented in more general fashion in the scope of [1], other
> things have been rejected).
>
> Looking forward to your comments!

Gentle ping!

The DT part has already received an Acked-by -- are there any objections
from the DRM side?

Thanks and best regards,
Michael

>
> [0] https://lore.kernel.org/lkml/[email protected]/
> [1] https://lore.kernel.org/lkml/[email protected]/
>
> ---
> Michael Riesch (2):
> drm/panel: sitronix-st7789v: add panel orientation support
> dt-bindings: display: add rotation property to sitronix,st7789v
>
> .../bindings/display/panel/sitronix,st7789v.yaml | 2 ++
> drivers/gpu/drm/panel/panel-sitronix-st7789v.c | 28 ++++++++++++++++++----
> 2 files changed, 25 insertions(+), 5 deletions(-)
> ---
> base-commit: 06c2afb862f9da8dc5efa4b6076a0e48c3fbaaa5
> change-id: 20230718-feature-st7789v-4d0c2c6e2429
>
> Best regards,