2023-07-18 08:32:53

by Raphael Gallais-Pou

Subject: [PATCH RESEND v2] staging: fbtft: ili9341: use macro FBTFT_REGISTER_SPI_DRIVER

Using FBTFT_REGISTER_DRIVER resolves to a NULL struct spi_device_id. This
ultimately causes a warning when the module probes. Fixes it.

Changes in v2:
- dropped MODULE_ALIAS changes
- changed commit log for more accurate description

Signed-off-by: Raphael Gallais-Pou <[email protected]>
---
drivers/staging/fbtft/fb_ili9341.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/fbtft/fb_ili9341.c b/drivers/staging/fbtft/fb_ili9341.c
index 9ccd0823c3ab..47e72b87d76d 100644
--- a/drivers/staging/fbtft/fb_ili9341.c
+++ b/drivers/staging/fbtft/fb_ili9341.c
@@ -145,7 +145,7 @@ static struct fbtft_display display = {
},
};

-FBTFT_REGISTER_DRIVER(DRVNAME, "ilitek,ili9341", &display);
+FBTFT_REGISTER_SPI_DRIVER(DRVNAME, "ilitek", "ili9341", &display);

MODULE_ALIAS("spi:" DRVNAME);
MODULE_ALIAS("platform:" DRVNAME);
--
2.41.0

2023-07-18 13:46:32

by Greg Kroah-Hartman

Subject: Re: [PATCH RESEND v2] staging: fbtft: ili9341: use macro FBTFT_REGISTER_SPI_DRIVER

On Tue, Jul 18, 2023 at 10:17:59AM +0200, Raphael Gallais-Pou wrote:
> Using FBTFT_REGISTER_DRIVER resolves to a NULL struct spi_device_id. This
> ultimately causes a warning when the module probes. Fixes it.
>
> Changes in v2:
> - dropped MODULE_ALIAS changes
> - changed commit log for more accurate description
>
> Signed-off-by: Raphael Gallais-Pou <[email protected]>
> ---
> drivers/staging/fbtft/fb_ili9341.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Why is this a resend?

And the changes need to go below the --- line as per the documentation.

thanks,

greg k-h

2023-07-18 16:56:00

by Raphael Gallais-Pou

Subject: Re: [PATCH RESEND v2] staging: fbtft: ili9341: use macro FBTFT_REGISTER_SPI_DRIVER

Hi,

Le 18/07/2023 à 15:33, Greg Kroah-Hartman a écrit :
> On Tue, Jul 18, 2023 at 10:17:59AM +0200, Raphael Gallais-Pou wrote:
>> Using FBTFT_REGISTER_DRIVER resolves to a NULL struct spi_device_id. This
>> ultimately causes a warning when the module probes. Fixes it.
>>
>> Changes in v2:
>> - dropped MODULE_ALIAS changes
>> - changed commit log for more accurate description
>>
>> Signed-off-by: Raphael Gallais-Pou <[email protected]>
>> ---
>> drivers/staging/fbtft/fb_ili9341.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Why is this a resend? >
> And the changes need to go below the --- line as per the documentation.

I messed up the first send and forgot the changelog.
Thanks for your insights, I understand now that I shouldn't have sent a
'RESEND', but rather a v3 with a third entry in the changelog.

Regards,
Raphaël
>
> thanks,
>
> greg k-h