2023-07-18 10:58:03

by Henning Schild

Subject: [PATCH 2/3] leds: simatic-ipc-leds: default config switch to platform switch

If a user did choose to enable Siemens Simatic platform support they
likely want the LED drivers to be enabled without having to flip more
config switches. So we make the LED drivers config switch default to
the platform driver switches value.

Signed-off-by: Henning Schild <[email protected]>
---
drivers/leds/simple/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/leds/simple/Kconfig b/drivers/leds/simple/Kconfig
index 44fa0f93cb3b..9666bf22d554 100644
--- a/drivers/leds/simple/Kconfig
+++ b/drivers/leds/simple/Kconfig
@@ -2,6 +2,7 @@
config LEDS_SIEMENS_SIMATIC_IPC
tristate "LED driver for Siemens Simatic IPCs"
depends on SIEMENS_SIMATIC_IPC
+ default SIEMENS_SIMATIC_IPC
help
This option enables support for the LEDs of several Industrial PCs
from Siemens.
--
2.41.0

2023-07-18 14:49:27

by Andy Shevchenko

Subject: Re: [PATCH 2/3] leds: simatic-ipc-leds: default config switch to platform switch

On Tue, Jul 18, 2023 at 12:52:12PM +0200, Henning Schild wrote:
> If a user did choose to enable Siemens Simatic platform support they
> likely want the LED drivers to be enabled without having to flip more
> config switches. So we make the LED drivers config switch default to
> the platform driver switches value.

Same as per previous patch.

--
With Best Regards,
Andy Shevchenko

2023-07-18 14:56:57

by Henning Schild

Subject: Re: [PATCH 2/3] leds: simatic-ipc-leds: default config switch to platform switch

Am Tue, 18 Jul 2023 17:21:04 +0300
schrieb Andy Shevchenko <[email protected]>:

> On Tue, Jul 18, 2023 at 12:52:12PM +0200, Henning Schild wrote:
> > If a user did choose to enable Siemens Simatic platform support they
> > likely want the LED drivers to be enabled without having to flip
> > more config switches. So we make the LED drivers config switch
> > default to the platform driver switches value.
>
> Same as per previous patch.
>

Same as per previous patch.

2023-07-19 09:03:08

by Lee Jones

Subject: Re: [PATCH 2/3] leds: simatic-ipc-leds: default config switch to platform switch

On Tue, 18 Jul 2023, Henning Schild wrote:

> Am Tue, 18 Jul 2023 17:21:04 +0300
> schrieb Andy Shevchenko <[email protected]>:
>
> > On Tue, Jul 18, 2023 at 12:52:12PM +0200, Henning Schild wrote:
> > > If a user did choose to enable Siemens Simatic platform support they
> > > likely want the LED drivers to be enabled without having to flip
> > > more config switches. So we make the LED drivers config switch
> > > default to the platform driver switches value.
> >
> > Same as per previous patch.
> >
>
> Same as per previous patch.

Same as per previous patch.

--
Lee Jones [李琼斯]

2023-07-19 11:08:17

by Henning Schild

Subject: Re: [PATCH 2/3] leds: simatic-ipc-leds: default config switch to platform switch

Am Wed, 19 Jul 2023 09:43:01 +0100
schrieb Lee Jones <[email protected]>:

> On Tue, 18 Jul 2023, Henning Schild wrote:
>
> > Am Tue, 18 Jul 2023 17:21:04 +0300
> > schrieb Andy Shevchenko <[email protected]>:
> >
> > > On Tue, Jul 18, 2023 at 12:52:12PM +0200, Henning Schild wrote:
> > > > If a user did choose to enable Siemens Simatic platform support
> > > > they likely want the LED drivers to be enabled without having
> > > > to flip more config switches. So we make the LED drivers config
> > > > switch default to the platform driver switches value.
> > >
> > > Same as per previous patch.
> > >
> >
> > Same as per previous patch.
>
> Same as per previous patch.
>

I will assume that you are asking me to "default y", as discussed on
that other patch. And will send a v2 accordingly.

In case the ordering of default, depends etc matters to you, please say
so.

Henning