2023-07-18 11:23:26

by Jason-ch Chen

[permalink] [raw]
Subject: [PATCH v4 3/4] dt-bindings: soc: mediatek: pwrap: Modify compatible for MT8188

From: jason-ch chen <[email protected]>

The reason for changing the patch was that while MT8188 uses the same
pwrap as MT8195, the original code was only applicable to 'compatible =
"mediatek,mt8188-pwrap"'. To resolve the DTBS check warning that
'['mediatek,mt8188-pwrap', 'mediatek,mt8195-pwrap', 'syscon'] is too
long', it is necessary to modify the code.

Signed-off-by: jason-ch chen <[email protected]>
---
.../devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml b/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
index a06ac2177444..4737e5f45d54 100644
--- a/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
+++ b/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
@@ -41,7 +41,6 @@ properties:
- mediatek,mt8173-pwrap
- mediatek,mt8183-pwrap
- mediatek,mt8186-pwrap
- - mediatek,mt8188-pwrap
- mediatek,mt8195-pwrap
- mediatek,mt8365-pwrap
- mediatek,mt8516-pwrap
@@ -50,6 +49,11 @@ properties:
- mediatek,mt8186-pwrap
- mediatek,mt8195-pwrap
- const: syscon
+ - items:
+ - enum:
+ - mediatek,mt8188-pwrap
+ - const: mediatek,mt8195-pwrap
+ - const: syscon

reg:
minItems: 1
--
2.18.0



2023-07-18 15:38:45

by Conor Dooley

[permalink] [raw]
Subject: Re: [PATCH v4 3/4] dt-bindings: soc: mediatek: pwrap: Modify compatible for MT8188

On Tue, Jul 18, 2023 at 07:09:46PM +0800, Jason-ch Chen wrote:
> From: jason-ch chen <[email protected]>
>
> The reason for changing the patch was that while MT8188 uses the same
> pwrap as MT8195,

> the original code was only applicable to 'compatible =
> "mediatek,mt8188-pwrap"'.

I don't really understand what this means. Did you mean, "the original
binding only allowed..."? If so,
Acked-by: Conor Dooley <[email protected]>

Thanks,
Conor.

> To resolve the DTBS check warning that
> '['mediatek,mt8188-pwrap', 'mediatek,mt8195-pwrap', 'syscon'] is too
> long', it is necessary to modify the code.
>
> Signed-off-by: jason-ch chen <[email protected]>
> ---
> .../devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml b/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
> index a06ac2177444..4737e5f45d54 100644
> --- a/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
> +++ b/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
> @@ -41,7 +41,6 @@ properties:
> - mediatek,mt8173-pwrap
> - mediatek,mt8183-pwrap
> - mediatek,mt8186-pwrap
> - - mediatek,mt8188-pwrap
> - mediatek,mt8195-pwrap
> - mediatek,mt8365-pwrap
> - mediatek,mt8516-pwrap
> @@ -50,6 +49,11 @@ properties:
> - mediatek,mt8186-pwrap
> - mediatek,mt8195-pwrap
> - const: syscon
> + - items:
> + - enum:
> + - mediatek,mt8188-pwrap
> + - const: mediatek,mt8195-pwrap
> + - const: syscon
>
> reg:
> minItems: 1
> --
> 2.18.0
>

Attachments:
(No filename) (1.84 kB)
 signature.asc (235.00 B)
 Download all attachments

2023-07-19 01:59:34

by Jason-ch Chen

[permalink] [raw]
Subject: Re: [PATCH v4 3/4] dt-bindings: soc: mediatek: pwrap: Modify compatible for MT8188

Hi Conor,

On Tue, 2023-07-18 at 16:13 +0100, Conor Dooley wrote:
> On Tue, Jul 18, 2023 at 07:09:46PM +0800, Jason-ch Chen wrote:
> > From: jason-ch chen <[email protected]>
> >
> > The reason for changing the patch was that while MT8188 uses the
> > same
> > pwrap as MT8195,
> > the original code was only applicable to 'compatible =
> > "mediatek,mt8188-pwrap"'.
>
> I don't really understand what this means. Did you mean, "the
> original
> binding only allowed..."? If so,
> Acked-by: Conor Dooley <[email protected]>
>

Thank you for your reply.
The actual test results confirm that the original binding is only
allowed to 'compatible = "mediatek,mt8188-pwrap"'.

> Thanks,
> Conor.
>
> > To resolve the DTBS check warning that
> > '['mediatek,mt8188-pwrap', 'mediatek,mt8195-pwrap', 'syscon'] is
> > too
> > long', it is necessary to modify the code.
> >
> > Signed-off-by: jason-ch chen <[email protected]>
> > ---
> > .../devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml | 6
> > +++++-
> > 1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yam
> > l
> > b/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yam
> > l
> > index a06ac2177444..4737e5f45d54 100644
> > ---
> > a/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yam
> > l
> > +++
> > b/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yam
> > l
> > @@ -41,7 +41,6 @@ properties:
> > - mediatek,mt8173-pwrap
> > - mediatek,mt8183-pwrap
> > - mediatek,mt8186-pwrap
> > - - mediatek,mt8188-pwrap
> > - mediatek,mt8195-pwrap
> > - mediatek,mt8365-pwrap
> > - mediatek,mt8516-pwrap
> > @@ -50,6 +49,11 @@ properties:
> > - mediatek,mt8186-pwrap
> > - mediatek,mt8195-pwrap
> > - const: syscon
> > + - items:
> > + - enum:
> > + - mediatek,mt8188-pwrap
> > + - const: mediatek,mt8195-pwrap
> > + - const: syscon
> >
> > reg:
> > minItems: 1
> > --
> > 2.18.0

Regards,
Jason

Subject: Re: [PATCH v4 3/4] dt-bindings: soc: mediatek: pwrap: Modify compatible for MT8188

Il 18/07/23 13:09, Jason-ch Chen ha scritto:
> From: jason-ch chen <[email protected]>
>
> The reason for changing the patch was that while MT8188 uses the same
> pwrap as MT8195, the original code was only applicable to 'compatible =
> "mediatek,mt8188-pwrap"'. To resolve the DTBS check warning that
> '['mediatek,mt8188-pwrap', 'mediatek,mt8195-pwrap', 'syscon'] is too
> long', it is necessary to modify the code.
>
> Signed-off-by: jason-ch chen <[email protected]>

The original binding allowed only "mediatek,mt8188-pwrap", while we need
to specify

compatible = "mediatek,mt8188-pwrap", "mediatek,mt8195-pwrap", "syscon";

for this node, as MT8188's PWRAP is fully compatible with MT8195 as it is
the very same IP, hence:

Reviewed-by: AngeloGioacchino Del Regno <[email protected]>

Regards,
Angelo

> ---
> .../devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml b/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
> index a06ac2177444..4737e5f45d54 100644
> --- a/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
> +++ b/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
> @@ -41,7 +41,6 @@ properties:
> - mediatek,mt8173-pwrap
> - mediatek,mt8183-pwrap
> - mediatek,mt8186-pwrap
> - - mediatek,mt8188-pwrap
> - mediatek,mt8195-pwrap
> - mediatek,mt8365-pwrap
> - mediatek,mt8516-pwrap
> @@ -50,6 +49,11 @@ properties:
> - mediatek,mt8186-pwrap
> - mediatek,mt8195-pwrap
> - const: syscon
> + - items:
> + - enum:
> + - mediatek,mt8188-pwrap
> + - const: mediatek,mt8195-pwrap
> + - const: syscon
>
> reg:
> minItems: 1